Implement SPARK Integration for Deferred R1CS Evaluations

.github/workflows/circuit_keys.yml

@@ -35,6 +35,9 @@ jobs:
             - name: Build provekit-cli
               run: cargo build --release --bin provekit-cli
 
+            - name: Build provekit-cli
+              run: cargo build --release --bin spark-cli
+
             - name: Setup Go
               uses: actions/setup-go@v5
               with:
@@ -53,14 +56,20 @@ jobs:
             - name: Generate Gnark inputs
               working-directory: ${{ env.CIRCUIT_DIR }}
               run: |
-                cargo run --release --bin provekit-cli prepare ./target/${{ env.CIRCUIT_NAME }}.json -p ./noir-provekit-prover.pkp -v ./noir-provekit-verifier.pkv
-                cargo run --release --bin provekit-cli prove ./noir-provekit-prover.pkp ./Prover.toml -o ./noir-proof.np
-                cargo run --release --bin provekit-cli generate-gnark-inputs ./noir-provekit-prover.pkp ./noir-proof.np
+                cargo run --release --bin provekit-cli prepare ./target/${{ env.CIRCUIT_NAME }}.json --pkp ./prover.pkp --pkv ./verifier.pkv
+                cargo run --release --bin provekit-cli prove ./prover.pkp ./Prover.toml -o ./proof.np
+                cargo run --release --bin provekit-cli generate-gnark-inputs ./prover.pkp ./proof.np
+
+            - name: Generate Spark Gnark inputs 
+              working-directory: ${{ env.CIRCUIT_DIR }}
+              run: |
+                cargo run --release --bin spark-cli -- prove --noir-proof-scheme ./prover.pkp --noir-proof ./proof.np 
+                cargo run --release --bin spark-cli -- verify --spark-proof spark_proof.json --noir-proof ./proof.np 
 
             - name: Run Gnark verifier
               working-directory: recursive-verifier
               run: |
-                go run cmd/cli/main.go --config "../${{ env.CIRCUIT_DIR }}/params_for_recursive_verifier" --r1cs "../${{ env.CIRCUIT_DIR }}/r1cs.json" --saveKeys "./keys"
+                go run cmd/cli/main.go --evaluation spark --config "../${{ env.CIRCUIT_DIR }}/params_for_recursive_verifier" --r1cs "../${{ env.CIRCUIT_DIR }}/r1cs.json" --saveKeys "./keys" --spark_config "../${{ env.CIRCUIT_DIR }}/gnark_spark_proof.json"
 
             - name: List keys
               working-directory: recursive-verifier

.github/workflows/end-to-end.yml

@@ -51,9 +51,11 @@ jobs:
       - name: Generate Gnark inputs
         working-directory: noir-examples/noir-passport-examples/complete_age_check
         run: |
-          cargo run --release --bin provekit-cli prepare ./target/complete_age_check.json -p ./noir-provekit-prover.pkp -v ./noir-provekit-verifier.pkv
-          cargo run --release --bin provekit-cli prove ./noir-provekit-prover.pkp ./Prover.toml -o ./noir-proof.np
-          cargo run --release --bin provekit-cli generate-gnark-inputs ./noir-provekit-prover.pkp ./noir-proof.np
+          cargo run --release --bin provekit-cli prepare ./target/complete_age_check.json --pkp ./prover.pkp --pkv ./verifier.pkv
+          cargo run --release --bin provekit-cli prove ./prover.pkp ./Prover.toml -o ./proof.np
+          cargo run --release --bin provekit-cli generate-gnark-inputs ./prover.pkp ./proof.np
+          cargo run --release --bin spark-cli -- prove --noir-proof-scheme ./prover.pkp --noir-proof ./proof.np 
+          cargo run --release --bin spark-cli -- verify --spark-proof spark_proof.json --noir-proof ./proof.np 
 
       - name: Run Gnark verifier
         working-directory: recursive-verifier
@@ -85,7 +87,7 @@ jobs:
           MONITOR_PID=$!
 
           # Run the main process
-          ./gnark-verifier --config "../noir-examples/noir-passport-examples/complete_age_check/params_for_recursive_verifier" --r1cs "../noir-examples/noir-passport-examples/complete_age_check/r1cs.json" --pk_url ${{ vars.AGE_CHECK_PK }} --vk_url ${{ vars.AGE_CHECK_VK }}
+          ./gnark-verifier --evaluation spark --config "../noir-examples/noir-passport-examples/complete_age_check/params_for_recursive_verifier" --spark_config "../noir-examples/noir-passport-examples/complete_age_check/gnark_spark_proof.json" --r1cs "../noir-examples/noir-passport-examples/complete_age_check/r1cs.json"  --pk_url ${{ vars.AGE_CHECK_SPARK_PK }} --vk_url ${{ vars.AGE_CHECK_SPARK_VK }}
 
           # Stop monitoring
           kill $MONITOR_PID

.gitignore

@@ -14,6 +14,8 @@
 *.np
 params_for_recursive_verifier
 params
+*.pkp
+*.pkv
 artifacts/
 
 # Don't ignore benchmarking artifacts

Cargo.toml

@@ -10,9 +10,11 @@ members = [
   "provekit/r1cs-compiler",
   "provekit/prover",
   "provekit/verifier",
+  "provekit/spark",
   "tooling/cli",
   "tooling/provekit-bench",
   "tooling/provekit-gnark",
+  "tooling/spark-cli",
   "tooling/verifier-server",
   "ntt",
 ]
@@ -86,6 +88,7 @@ provekit-prover = { path = "provekit/prover" }
 provekit-r1cs-compiler = { path = "provekit/r1cs-compiler" }
 provekit-verifier = { path = "provekit/verifier" }
 provekit-verifier-server = { path = "tooling/verifier-server" }
+provekit-spark = { path = "provekit/spark" }
 
 # 3rd party
 anyhow = "1.0.93"

README.md

@@ -12,45 +12,64 @@ noirup --version v1.0.0-beta.11
 
 ## Demo instructions
 
-> _NOTE:_ The example below is being run for single example `poseidon-rounds`. You can use different example to run same commands.
+> _NOTE:_ The example below is being run for single example `complete_age_check`. You can use different example to run same commands.
 
-Compile the Noir circuit:
+1. Compile the Noir circuit:
 
 ```sh
-cd noir-examples/poseidon-rounds
+cd noir-examples/noir-passport-examples/complete_age_check
 nargo compile
 ```
 
 Prepare the Noir program (generates prover and verifier files):
 
 ```sh
-cargo run --release --bin provekit-cli prepare ./target/basic.json --pkp ./prover.pkp --pkv ./verifier.pkv
+cargo run --release --bin provekit-cli prepare ./target/complete_age_check.json --pkp ./prover.pkp --pkv ./verifier.pkv
 ```
 
-Generate the Noir Proof using the input Toml:
+3. Generate the Noir Proof using the input Toml:
 
 ```sh
 cargo run --release --bin provekit-cli prove ./prover.pkp ./Prover.toml -o ./proof.np
 ```
 
-Verify the Noir Proof:
+(Optional) Verify the Noir Proof:
 
 ```sh
 cargo run --release --bin provekit-cli verify ./verifier.pkv ./proof.np
 ```
 
-Generate inputs for Gnark circuit:
+4. Generate inputs for Gnark circuit:
 
 ```sh
 cargo run --release --bin provekit-cli generate-gnark-inputs ./prover.pkp ./proof.np
 ```
 
-Recursively verify in a Gnark proof (reads the proof from `../ProveKit/prover/proof`):
+5. Recursively verify in a Gnark proof (reads the proof from `../ProveKit/prover/proof`). We provide two methods to prove deferred evaluations.
+
+   5.1. Spark: Spark prover generates proof of MLE evaluation
 
-```sh
-cd ../../recursive-verifier
-go run .
-```
+      5.1.1 Generate the Spark Proof:
+      ```sh
+      cargo run --release --bin spark-cli -- prove --noir-proof-scheme ./prover.pkp --noir-proof ./proof.np 
+      ```
+
+      (Optional) Verify the Spark Proof:
+      ```sh
+      cargo run --release --bin spark-cli -- verify --spark-proof spark_proof.json --noir-proof ./proof.np 
+      ```
+
+      5.1.2 Recursively verify 
+      ```sh
+      cd ../../../recursive-verifier/cmd/cli
+      go run . --evaluation spark --config ../../../noir-examples/noir-passport-examples/complete_age_check/params_for_recursive_verifier --spark_config ../../../noir-examples/noir-passport-examples/complete_age_check/gnark_spark_proof.json --r1cs ../../../noir-examples/noir-passport-examples/complete_age_check/r1cs.json
+      ```
+
+   5.2. Direct evaluation: verifier directly evaluates MLEs of R1CS matrices
+   ```sh
+   cd ../../../recursive-verifier/cmd/cli
+   go run . --evaluation direct --config ../../../noir-examples/noir-passport-examples/complete_age_check/params_for_recursive_verifier --spark_config ../../../noir-examples/noir-passport-examples/complete_age_check/gnark_spark_proof.json --r1cs ../../../noir-examples/noir-passport-examples/complete_age_check/r1cs.json
+   ```
 
 ### Benchmarking
 
@@ -160,9 +179,11 @@ ProveKit follows a modular architecture with clear separation of concerns:
 - **`provekit/r1cs-compiler/`** - R1CS compilation logic and Noir integration  
 - **`provekit/prover/`** - Proving functionality with witness generation
 - **`provekit/verifier/`** - Verification functionality
+- **`provekit/spark/`** - Spark logic
 
 ### Tooling
 - **`tooling/cli/`** - Command-line interface (`provekit-cli`)
+- **`tooling/spark-cli/`** - Command-line interface for Spark(`spark-cli`)
 - **`tooling/provekit-bench/`** - Benchmarking infrastructure
 - **`tooling/provekit-gnark/`** - Gnark integration utilities
 
@@ -172,7 +193,7 @@ ProveKit follows a modular architecture with clear separation of concerns:
 
 ### Examples & Tests
 - **`noir-examples/`** - Example circuits and test programs
-- **`gnark-whir/`** - Go-based recursive verification using Gnark
+- **`recursive-verifier/`** - Go-based recursive verification using Gnark
 
 ## Dependencies
 

provekit/common/Cargo.toml

@@ -23,6 +23,7 @@ ark-crypto-primitives.workspace = true
 ark-ff.workspace = true
 ark-serialize.workspace = true
 ark-std.workspace = true
+ark-poly.workspace = true
 spongefish.workspace = true
 spongefish-pow.workspace = true
 whir.workspace = true

provekit/common/src/gnark.rs

@@ -0,0 +1,76 @@
+use {
+    crate::WhirConfig,
+    ark_poly::EvaluationDomain,
+    serde::{Deserialize, Serialize},
+};
+
+#[derive(Debug, Serialize, Deserialize)]
+
+pub struct WHIRConfigGnark {
+    /// number of rounds
+    pub n_rounds:               usize,
+    /// rate
+    pub rate:                   usize,
+    /// number of variables
+    pub n_vars:                 usize,
+    /// folding factor
+    pub folding_factor:         Vec<usize>,
+    /// out of domain samples
+    pub ood_samples:            Vec<usize>,
+    /// number of queries
+    pub num_queries:            Vec<usize>,
+    /// proof of work bits
+    pub pow_bits:               Vec<i32>,
+    /// final queries
+    pub final_queries:          usize,
+    /// final proof of work bits
+    pub final_pow_bits:         i32,
+    /// final folding proof of work bits
+    pub final_folding_pow_bits: i32,
+    /// domain generator string
+    pub domain_generator:       String,
+    /// batch size
+    pub batch_size:             usize,
+}
+
+impl WHIRConfigGnark {
+    pub fn new(whir_params: &WhirConfig) -> Self {
+        WHIRConfigGnark {
+            n_rounds:               whir_params
+                .folding_factor
+                .compute_number_of_rounds(whir_params.mv_parameters.num_variables)
+                .0,
+            rate:                   whir_params.starting_log_inv_rate,
+            n_vars:                 whir_params.mv_parameters.num_variables,
+            folding_factor:         (0..(whir_params
+                .folding_factor
+                .compute_number_of_rounds(whir_params.mv_parameters.num_variables)
+                .0))
+                .map(|round| whir_params.folding_factor.at_round(round))
+                .collect(),
+            ood_samples:            whir_params
+                .round_parameters
+                .iter()
+                .map(|x| x.ood_samples)
+                .collect(),
+            num_queries:            whir_params
+                .round_parameters
+                .iter()
+                .map(|x| x.num_queries)
+                .collect(),
+            pow_bits:               whir_params
+                .round_parameters
+                .iter()
+                .map(|x| x.pow_bits as i32)
+                .collect(),
+            final_queries:          whir_params.final_queries,
+            final_pow_bits:         whir_params.final_pow_bits as i32,
+            final_folding_pow_bits: whir_params.final_folding_pow_bits as i32,
+            domain_generator:       format!(
+                "{}",
+                whir_params.starting_domain.backing_domain.group_gen()
+            ),
+            batch_size:             whir_params.batch_size,
+        }
+    }
+}

provekit/common/src/lib.rs

@@ -1,24 +1,24 @@
 pub mod file;
+pub mod gnark;
 mod interner;
 mod noir_proof_scheme;
 mod prover;
 mod r1cs;
 pub mod skyscraper;
+pub mod spark;
 mod sparse_matrix;
 pub mod utils;
 mod verifier;
 mod whir_r1cs;
 pub mod witness;
 
-use crate::{
-    interner::{InternedFieldElement, Interner},
-    sparse_matrix::{HydratedSparseMatrix, SparseMatrix},
-};
+use crate::interner::{InternedFieldElement, Interner};
 pub use {
     acir::FieldElement as NoirElement,
     noir_proof_scheme::{NoirProof, NoirProofScheme},
     prover::Prover,
     r1cs::R1CS,
+    sparse_matrix::{HydratedSparseMatrix, SparseMatrix},
     verifier::Verifier,
     whir::crypto::fields::Field256 as FieldElement,
     whir_r1cs::{IOPattern, WhirConfig, WhirR1CSProof, WhirR1CSScheme},

provekit/common/src/noir_proof_scheme.rs

@@ -1,5 +1,6 @@
 use {
     crate::{
+        spark::SparkStatement,
         whir_r1cs::{WhirR1CSProof, WhirR1CSScheme},
         witness::{LayeredWitnessBuilders, NoirWitnessGenerator},
         NoirElement, R1CS,
@@ -21,6 +22,7 @@ pub struct NoirProofScheme {
 #[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
 pub struct NoirProof {
     pub whir_r1cs_proof: WhirR1CSProof,
+    pub spark_statement: SparkStatement,
 }
 
 impl NoirProofScheme {

provekit/common/src/spark.rs

@@ -0,0 +1,35 @@
+use {
+    crate::{utils::serde_ark, FieldElement},
+    ark_serialize::{CanonicalDeserialize, CanonicalSerialize},
+    serde::{Deserialize, Serialize},
+};
+
+#[derive(
+    Debug, Clone, PartialEq, Eq, CanonicalSerialize, Serialize, CanonicalDeserialize, Deserialize,
+)]
+pub struct Point {
+    #[serde(with = "serde_ark")]
+    pub row: Vec<FieldElement>,
+    #[serde(with = "serde_ark")]
+    pub col: Vec<FieldElement>,
+}
+
+#[derive(
+    Debug, Clone, PartialEq, Eq, CanonicalSerialize, Serialize, CanonicalDeserialize, Deserialize,
+)]
+pub struct ClaimedValues {
+    #[serde(with = "serde_ark")]
+    pub a: FieldElement,
+    #[serde(with = "serde_ark")]
+    pub b: FieldElement,
+    #[serde(with = "serde_ark")]
+    pub c: FieldElement,
+}
+
+#[derive(
+    Debug, Clone, PartialEq, Eq, CanonicalSerialize, Serialize, CanonicalDeserialize, Deserialize,
+)]
+pub struct SparkStatement {
+    pub point_to_evaluate: Point,
+    pub claimed_values:    ClaimedValues,
+}

provekit/common/src/utils/sumcheck.rs

@@ -152,6 +152,7 @@ pub fn calculate_evaluations_over_boolean_hypercube_for_eq(
 }
 
 /// Evaluates the equality polynomial recursively.
+#[inline(always)]
 fn eval_eq(eval: &[FieldElement], out: &mut [FieldElement], scalar: FieldElement) {
     debug_assert_eq!(out.len(), 1 << eval.len());
     let size = out.len();

provekit/prover/Cargo.toml

@@ -12,6 +12,7 @@ repository.workspace = true
 # Workspace crates
 provekit-common.workspace = true
 skyscraper.workspace = true
+serde_json.workspace = true
 
 # Noir language
 acir.workspace = true

provekit/prover/src/lib.rs

@@ -92,12 +92,15 @@ impl Prove for Prover {
             .context("While verifying R1CS instance")?;
 
         // Prove R1CS instance
-        let whir_r1cs_proof = self
+        let (whir_r1cs_proof, spark_statement) = self
             .whir_for_witness
             .prove(self.r1cs, witness)
             .context("While proving R1CS instance")?;
 
-        Ok(NoirProof { whir_r1cs_proof })
+        Ok(NoirProof {
+            whir_r1cs_proof,
+            spark_statement,
+        })
     }
 
     fn create_witness_io_pattern(&self) -> IOPattern {