feat: document packages and unify into a single rust core #35
Conversation
paolodamico
requested review from
Guardiola31337,
SeanROlszewski,
andy-t-wang and
decentralgabe
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| members = [ | ||
| "rust/core", | ||
| "rust/uniffi-bindings", | ||
| "rust/uniffi-bindgen-bin", | ||
| "rust/wasm", | ||
| ] |
There was a problem hiding this comment.
The workspace members list now omits rust/wasm, but the JavaScript package still runs scripts/build-wasm.sh, which hard-codes that path and exits early when the directory is missing. After this change, npm run build (or npm run build:wasm) in js/packages/core fails with “Error: WASM crate not found at …/rust/wasm” because the referenced crate no longer exists. Update the build script to target the new core-based WASM bindings (or keep the crate) to restore the JS package build.
Useful? React with 👍 / 👎.
No description provided.