[ID-1226] rust crate publishing #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decentralgabe
commented
Dec 4, 2025
.github/workflows/publish-rust.yml
Outdated
|
|
||
| - name: Cargo publish dry run | ||
| env: | ||
| CARGO_REGISTRY_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }} |
Contributor
Author
There was a problem hiding this comment.
@paolodamico will need your help with this
Collaborator
There was a problem hiding this comment.
remove, a token is not needed. publishing should only be done with trusted publishing
decentralgabe
requested review from
Guardiola31337,
SeanROlszewski,
andy-t-wang and
paolodamico
as code owners
paolodamico
reviewed
Dec 5, 2025
|
|
||
| - name: Run Rust tests | ||
| run: cargo test --package idkit-core | ||
| run: cargo test --package idkit --all-features |
Collaborator
There was a problem hiding this comment.
you probably also want to run tests with --no-default-features
paolodamico
reviewed
Dec 5, 2025
| ``` | ||
| ┌─────────────────────────────────────┐ | ||
| │ Rust Core (idkit-core) │ | ||
| │ Rust Core (idkit) │ |
Collaborator
There was a problem hiding this comment.
hmm shouldn't foreign bindings still inherit from idkit-core? so idkit-core (Rust package) -> idkit-js (with react), idkit-swift, idkit-kotlin
Contributor
Author
There was a problem hiding this comment.
yeah it's just a naming thing, I made it idkit so the rust package is idkit not idkit core, even though it is core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.