-
Notifications
You must be signed in to change notification settings - Fork 14
Repository maintenance #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Greptile OverviewGreptile SummaryThis PR comprehensively modernizes the repository's tooling by consolidating ESLint, Prettier, and Jest into Biome and Vitest, while migrating the build system to tsdown for dual ESM/CJS output. Key Changes
Code Quality ImprovementsBiome automatically fixed several code quality issues:
Testing & Build
No security issues, custom rule violations, or breaking changes detected. Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Repo as Repository
participant ESLint as ESLint/Prettier/Jest
participant Biome as Biome
participant Vitest as Vitest
participant tsdown as tsdown
participant Deps as Dependencies
Dev->>Repo: Initiate tooling migration
Note over Repo,ESLint: Remove old tooling
Repo->>ESLint: Delete .eslintrc.cjs, .prettierrc
Repo->>ESLint: Delete jest.config.ts
Repo->>Repo: Remove ESLint/Prettier/Jest from package.json
Note over Repo,Biome: Add Biome
Dev->>Repo: Create biome.json configuration
Repo->>Biome: Configure linting & formatting rules
Biome->>Repo: Enforce import extensions, quotes, trailing commas
Note over Repo,Vitest: Add Vitest
Dev->>Repo: Create vitest.config.ts
Repo->>Vitest: Configure test environments (jsdom/node)
Repo->>Vitest: Set coverage thresholds (80%)
Dev->>Repo: Update test files (jest → vi)
Note over Repo,tsdown: Add tsdown
Dev->>Repo: Create tsdown.config.ts
Repo->>tsdown: Configure dual ESM/CJS build
tsdown->>Repo: Generate dist/index.mjs & dist/index.cjs
Note over Repo,Deps: Update dependencies
Dev->>Deps: Update @workos-inc/node, iron-session, jose
Dev->>Deps: Update TypeScript, Remix, testing libraries
Repo->>Repo: Update tsconfig.json to strictest/node24
Note over Repo: Apply Biome fixes
Biome->>Repo: Fix import ordering
Biome->>Repo: Replace isNaN with Number.isNaN
Biome->>Repo: Fix string concatenation
Biome->>Repo: Remove unused catch bindings
Biome->>Repo: Add type annotations
Repo->>Dev: Migration complete
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
26 files reviewed, no comments
Signed-off-by: Sora Morimoto <sora@morimoto.io>
33e1331 to
0c8a706
Compare
|
Gentle ping |
|
Hey thanks for this! A couple of notes:
Given this, we'd definitely like to accept this but would like to hold off on the Biome change for now. I'd be happy to help split that out and get this merged. What do you think? Another note: given the trajectory for Remix, this project will likely be reworked to support the new Remix when that's ready. For the current architecture we have authkit-react-router which is effectively a fork of this project. We'd want to keep parity over there with the changes we make here, which I'm more than happy to do! Thanks again! |
Uh oh!
There was an error while loading. Please reload this page.