Skip to content

fix: handle dependency update command failures#401

Merged
Patrick Lafrance (patricklafrance) merged 2 commits intomainfrom
fix/update-deps-failure-handling
Mar 10, 2026
Merged

fix: handle dependency update command failures#401
Patrick Lafrance (patricklafrance) merged 2 commits intomainfrom
fix/update-deps-failure-handling

Conversation

@patricklafrance

Summary

  • Added pnpm override for fast-xml-parser to <5.5.0 — version 5.5.0 was published with a broken local file: dependency (/home/runner/work/fxp-builder) that causes pnpm update to fail in CI
  • Updated the dependency update prompt to create a GitHub issue when pnpm update-outdated-deps itself fails (non-zero exit code), instead of silently stopping because no package.json files changed

Fixes the silent failure observed in https://github.com/workleap/wl-web-configs/actions/runs/22907177971

Test plan

  • Trigger the update-dependencies workflow manually and verify it completes successfully
  • Verify that if pnpm update-outdated-deps fails, an issue is created

🤖 Generated with Claude Code

… fast-xml-parser@5.5.0

Add pnpm override for fast-xml-parser <5.5.0 to avoid a version published
with a broken local path dependency. Update the dependency update prompt to
create a GitHub issue when the update command itself fails, instead of
silently stopping.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings March 10, 2026 20:09
@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 10, 2026

Open in StackBlitz

@workleap/browserslist-config

pnpm add https://pkg.pr.new/@workleap/browserslist-config@401

@workleap/eslint-configs

pnpm add https://pkg.pr.new/@workleap/eslint-configs@401

@workleap/postcss-configs

pnpm add https://pkg.pr.new/@workleap/postcss-configs@401

@workleap/rsbuild-configs

pnpm add https://pkg.pr.new/@workleap/rsbuild-configs@401

@workleap/rslib-configs

pnpm add https://pkg.pr.new/@workleap/rslib-configs@401

@workleap/stylelint-configs

pnpm add https://pkg.pr.new/@workleap/stylelint-configs@401

@workleap/swc-configs

pnpm add https://pkg.pr.new/@workleap/swc-configs@401

@workleap/tsup-configs

pnpm add https://pkg.pr.new/@workleap/tsup-configs@401

@workleap/typescript-configs

pnpm add https://pkg.pr.new/@workleap/typescript-configs@401

@workleap/webpack-configs

pnpm add https://pkg.pr.new/@workleap/webpack-configs@401

commit: 718a58e

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds safeguards to keep the dependency-update automation reliable in CI by pinning away from a known-bad fast-xml-parser release and ensuring failures in the update command are surfaced via a GitHub issue.

Changes:

  • Added a pnpm override to prevent resolving fast-xml-parser@5.5.0 (which breaks pnpm update due to an invalid local file: dependency).
  • Updated the dependency-update agent prompt to open a GitHub issue when pnpm update-outdated-deps fails (non-zero exit) instead of stopping silently.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
pnpm-lock.yaml Records the fast-xml-parser override in the lockfile to avoid the broken version during installs/updates.
package.json Adds pnpm.overrides to enforce the fast-xml-parser constraint at the workspace root.
.github/prompts/update-dependencies.md Improves automation instructions to create an issue when the update command itself fails.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

package.json Outdated
Comment on lines +71 to +75
"pnpm": {
"overrides": {
"fast-xml-parser": "<5.5.0"
}
},
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repo docs for pnpm overrides recommend defining workspace-wide overrides in pnpm-workspace.yaml rather than package.json. Consider moving this override there to keep all pnpm-specific config centralized (and let the lockfile be derived from it), unless there’s a reason it must live in package.json.

Copilot uses AI. Check for mistakes.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@patricklafrance Patrick Lafrance (patricklafrance) merged commit 08f70de into main Mar 10, 2026
6 of 7 checks passed
@patricklafrance Patrick Lafrance (patricklafrance) deleted the fix/update-deps-failure-handling branch March 10, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants