fix: remove redundant build command from serve-build scripts in package.json files#395
Merged
Patrick Lafrance (patricklafrance) merged 1 commit intomainfrom Mar 2, 2026
Conversation
…ge.json files feat: add transit task dependency in turbo.json for linting and type checking
Copilot started reviewing on behalf of
Patrick Lafrance (patricklafrance)
March 2, 2026 17:51
View session
@workleap/browserslist-config
@workleap/eslint-configs
@workleap/postcss-configs
@workleap/rsbuild-configs
@workleap/rslib-configs
@workleap/stylelint-configs
@workleap/swc-configs
@workleap/tsup-configs
@workleap/typescript-configs
@workleap/webpack-configs
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates monorepo task orchestration to avoid redundant builds when serving built sample apps, aligning with Turborepo’s task graph and the monorepo audit findings in #394.
Changes:
- Remove redundant
pnpm build &&prefix fromserve-buildscripts in the webpack and rsbuild sample apps (rely onturbo.jsonserve-build→builddependency). - Introduce a Turborepo
transittask and makeeslint/stylelint/typecheckdepend on it to improve dependency-aware cache invalidation without forcing sequential execution. - Update internal skill/docs and the audit prompt with clarified package names and an explicit “accepted findings” ignore list.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
turbo.json |
Adds transit task and hooks it into lint/typecheck tasks for dependency-aware caching behavior. |
samples/webpack/app/package.json |
Removes redundant build invocation from serve-build. |
samples/rsbuild/app/package.json |
Removes redundant build invocation from serve-build. |
agent-skills/workleap-web-configs/SKILL.md |
Corrects package identifiers to use the proper @workleap/* names. |
.github/prompts/audit-monorepo.md |
Documents an ignore list for audit findings that are accepted by maintainers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Patrick Lafrance (patricklafrance)
merged commit 88a683a
into
main
11 of 12 checks passed
Patrick Lafrance (patricklafrance)
deleted the
chore/fix-audit-2026-03-01
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #394