fix: handle dependency update command failures#401
fix: handle dependency update command failures#401Patrick Lafrance (patricklafrance) merged 2 commits intomainfrom
Conversation
… fast-xml-parser@5.5.0 Add pnpm override for fast-xml-parser <5.5.0 to avoid a version published with a broken local path dependency. Update the dependency update prompt to create a GitHub issue when the update command itself fails, instead of silently stopping. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@workleap/browserslist-config
@workleap/eslint-configs
@workleap/postcss-configs
@workleap/rsbuild-configs
@workleap/rslib-configs
@workleap/stylelint-configs
@workleap/swc-configs
@workleap/tsup-configs
@workleap/typescript-configs
@workleap/webpack-configs
commit: |
There was a problem hiding this comment.
Pull request overview
Adds safeguards to keep the dependency-update automation reliable in CI by pinning away from a known-bad fast-xml-parser release and ensuring failures in the update command are surfaced via a GitHub issue.
Changes:
- Added a pnpm override to prevent resolving
fast-xml-parser@5.5.0(which breakspnpm updatedue to an invalid localfile:dependency). - Updated the dependency-update agent prompt to open a GitHub issue when
pnpm update-outdated-depsfails (non-zero exit) instead of stopping silently.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
pnpm-lock.yaml |
Records the fast-xml-parser override in the lockfile to avoid the broken version during installs/updates. |
package.json |
Adds pnpm.overrides to enforce the fast-xml-parser constraint at the workspace root. |
.github/prompts/update-dependencies.md |
Improves automation instructions to create an issue when the update command itself fails. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
package.json
Outdated
| "pnpm": { | ||
| "overrides": { | ||
| "fast-xml-parser": "<5.5.0" | ||
| } | ||
| }, |
There was a problem hiding this comment.
Repo docs for pnpm overrides recommend defining workspace-wide overrides in pnpm-workspace.yaml rather than package.json. Consider moving this override there to keep all pnpm-specific config centralized (and let the lockfile be derived from it), unless there’s a reason it must live in package.json.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
08f70de
into
main
Summary
fast-xml-parserto<5.5.0— version5.5.0was published with a broken localfile:dependency (/home/runner/work/fxp-builder) that causespnpm updateto fail in CIpnpm update-outdated-depsitself fails (non-zero exit code), instead of silently stopping because nopackage.jsonfiles changedFixes the silent failure observed in https://github.com/workleap/wl-web-configs/actions/runs/22907177971
Test plan
pnpm update-outdated-depsfails, an issue is created🤖 Generated with Claude Code