chore: remove token#226
Merged
Alexandre Asselin (alexasselin008) merged 2 commits intomasterfrom Oct 23, 2025
Merged
Conversation
Updated permissions comment for id-token and removed NPM_TOKEN environment variable.
✅ Deploy Preview for wl-orbiter-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for wl-orbiter-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Bump version for OIDC publish testing.
Alexandre Asselin (alexasselin008)
changed the title
Alexandre Asselin (alexasselin008)
marked this pull request as ready for review
There was a problem hiding this comment.
Pull Request Overview
This PR removes the NPM_TOKEN environment variable from the GitHub Actions workflow in favor of using OIDC (OpenID Connect) for npm Trusted Publishing. The change updates the permission comment to reflect this new authentication method.
- Removed NPM_TOKEN environment variable from the changeset workflow
- Updated the id-token permission comment to clarify its purpose for OIDC authentication
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/changeset.yml | Removed NPM_TOKEN environment variable and updated id-token permission comment to reference OIDC |
| .changeset/giant-buttons-visit.md | Added changeset entry to document this change and test OIDC publishing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira issue link: SSD-3983
Updated permissions comment for id-token and removed NPM_TOKEN environment variable.
Issue:
Summary
What I did
How to test
Is this testable with Jest or Chromatic screenshots?
Does this need an update to the documentation?
If your answer is yes to any of these, please make sure to include it in your PR.