Skip to content

try fixing lerna publish issue #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Michael Ignoto (Ignotos) wants to merge 1 commit into from
Closed

try fixing lerna publish issue #888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name: Publish Packages
on:
push:
branches: [main]
workflow_dispatch:
Comment on lines 3 to +6
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding workflow_dispatch allows manually running this workflow from any selected ref/branch, which can unintentionally publish packages to npm from a non-main commit (since this workflow has an npm token and runs yarn publish-ci). Consider gating the job/step so publishing only occurs when github.ref is refs/heads/main (or otherwise explicitly require/validate the target ref via inputs) to avoid accidental or unsafe releases.

Copilot uses AI. Check for mistakes.

jobs:
version:
Expand Down
4 changes: 3 additions & 1 deletion lerna.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@
"command": {
"version": {
"message": "chore(release): publish",
"allowBranch": ["main", "fix/*"],
"allowBranch": ["main", "fix/*"]
},
"publish": {
"registry": "https://registry.npmjs.org"
}
},
Expand Down
Loading