EP-6633: Fix broken css caused by redundant layer declarations#882
Merged
Patrick DeVries (PatrickDeVries) merged 2 commits intomainfrom Jul 24, 2025
Merged
EP-6633: Fix broken css caused by redundant layer declarations#882Patrick DeVries (PatrickDeVries) merged 2 commits intomainfrom
Patrick DeVries (PatrickDeVries) merged 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: c591701 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for igloo-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a CSS build issue caused by redundant @layer declarations in the List and Tabs components that were already defined in globals.scss. The redundant declarations were causing malformed CSS output (missing semicolons) that broke styling in dependent components like Select.
- Removed duplicate
@layer hopper-design-system, hopper-icons, igloo;declarations from List and Tabs SCSS files - Added changeset documentation for the patch releases
- Fixed CSS compilation issues that were causing broken styling in Select component
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/Tabs/src/tabs.scss | Removed redundant CSS layer declaration |
| packages/List/src/list.scss | Removed redundant CSS layer declaration |
| .changeset/itchy-frogs-push.md | Added changeset entry documenting the patch fix |
Victor Trinh (victortrinh2)
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The List and Tabs both redeclare the CSS Layers for some reason, although this is already done in globals.scss. For whatever reason the redundant declaration was resulting in the build CSS for List including the layer tag at the end with no semicolon. This produced no issues for the List itself, but when the Select used that CSS block the missing semicolon broke the CSS following it:
Resulting in broken select items:
Removing the redundant layer fixes the built CSS