EP-6633 Restore accidentally removed CSS variables#880
Merged
Patrick DeVries (PatrickDeVries) merged 3 commits intomainfrom Jul 22, 2025
Merged
EP-6633 Restore accidentally removed CSS variables#880Patrick DeVries (PatrickDeVries) merged 3 commits intomainfrom
Patrick DeVries (PatrickDeVries) merged 3 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 4b178f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for igloo-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR restores CSS variables that were accidentally removed during a rebranding cleanup process. The changes ensure that all necessary CSS custom properties are available for proper component styling and functionality.
Key changes:
- Restored missing CSS variables across multiple component packages
- Fixed a code optimization in ComboboxInput by inlining icon components
- Added appropriate comments to organize CSS variable sections
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/Toaster/src/toaster.scss | Added "Default" comment section |
| packages/TextEditor/src/plugins/floating-link-editor.scss | Restored z-index and width CSS variables |
| packages/Select/src/select.scss | Restored number-of-option-to-display variable |
| packages/Select/src/select-value.scss | Restored disabled color variable |
| packages/Select/src/select-option.scss | Restored selected background variable |
| packages/Select/src/select-input.scss | Removed extra blank line |
| packages/HelperText/src/helper-text.scss | Added "Default" comment section |
| packages/Dropdown/src/dropdown.scss | Restored z-index variables and added click handler section |
| packages/Disclosure/src/disclosure.scss | Added "Low Contrast" comment section |
| packages/Datepicker/src/datepicker.scss | Restored cell border variables |
| packages/Combobox/src/ComboboxInput.tsx | Inlined icon components instead of using variables |
| packages/Color/src/color.scss | Restored background variable (appears circular) |
| packages/Checkbox/src/checkbox.scss | Restored completion radius and one-px variables, reordered existing variables |
| packages/Button/src/button.scss | Restored disabled danger text variable, reordered premium text variables |
| packages/Breadcrumb/src/breadcrumb.scss | Restored hover border color variable |
| packages/AreaChart/src/chart-tooltip.scss | Moved circle background variable from selector to root |
| .changeset/real-moose-lick.md | Added changeset documenting the restoration |
Victor Trinh (victortrinh2)
approved these changes
Jul 22, 2025
Patrick DeVries (PatrickDeVries)
deleted the
bug/EP-6633_restore-missing-tokens
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I accidentally removed a few CSS variables when cleaning up the old brand styles. I naively replaced the old styles with the rebrand styles, but a few CSS vars were only defined in the first block so this removed them. This restores them. To find the issues I went through and made sure each CSS var declaration block has the same or more vars as the original block did.