EP-6630: Clean up rebrand styles for components E-P#876
Merged
Patrick DeVries (PatrickDeVries) merged 9 commits intomainfrom Jul 21, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 12c96e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for igloo-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes legacy default styling and conditional logic for non-Workleap branding across components E–P, streamlining the code to only support the new Workleap design tokens and behaviors.
- Deleted obsolete
:rootCSS variables and old brand toggles, keeping only Workleap overrides. - Stripped out
getBrandchecks and legacy icon variants, standardizing on new Workleap icons and fixed conversions. - Adjusted import orders and minor style tweaks (e.g., Popover min-width update).
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/ProgressBar/src/progress-bar.scss | Removed default root variables, left only Workleap overrides |
| packages/Popover/src/popover.scss | Deleted outdated tokens, updated min-width and removed brand block |
| packages/Popover/src/Popover.tsx | Removed getBrand, simplified fromPxToRem base logic |
| packages/PieChart/src/pie-chart.scss | Cleared legacy root styles, retained Workleap variables |
| packages/Pager/src/pager.scss | Stripped default CSS vars, preserved only Workleap definitions |
| packages/Pager/src/Pager.tsx | Eliminated getBrand, always use medium-sized arrows |
| packages/OptionButton/src/option-button.scss | Removed legacy styling variables, kept Workleap overrides |
| packages/OptionButton/src/OptionButton.tsx | Dropped getBrand and legacy icons, now only new icon imports |
| packages/Modal/src/modal.scss | Purged default modal tokens, left Workleap customizations |
| packages/Metric/src/score.scss | Deleted root score variables, retained only Workleap settings |
| packages/Metric/src/metric.scss | Removed default metric tokens, kept Workleap definitions |
| packages/Metric/src/Score.tsx | Stripped getBrand, always render new arrow icons |
| packages/Metric/src/Metric.tsx | Removed getBrand/HelpSolid, standardized on QuestionIcon |
| packages/List/src/list.scss | Cleared default list tokens, left Workleap overrides |
| packages/List/src/list-item.scss | Removed default list-item vars, preserved Workleap custom styles |
| packages/List/src/ListItem.tsx | Got rid of getBrand, always use UserIcon |
| packages/Input/src/input.scss | Stripped legacy input tokens, kept only Workleap variables |
| packages/IconButton/src/icon-button.scss | Deleted default icon-button vars, kept Workleap definitions |
| packages/Hyperlink/src/hyperlink.scss | Removed outdated hyperlink tokens, left only Workleap variants |
| packages/HelperText/src/helper-text.scss | Purged default helper-text vars, retained Workleap overrides |
| packages/FormGroup/src/form-group.scss | Cleared root form-group variables, kept Workleap styles |
| packages/Filter/src/filter.scss | Removed legacy filter tokens, preserved Workleap definitions |
| .changeset/old-weeks-pump.md | Added changeset entries for major/minor bumps across packages |
Comments suppressed due to low confidence (4)
packages/Popover/src/Popover.tsx:156
- Since the
baseparameter never varies and is always 16, consider removing it and hardcoding the conversion (e.g.,const fromPxToRem = (value: number): string =>${value/16}rem``) to simplify the function signature.
const fromPxToRem = (value: number, base = 16): string =>
packages/OptionButton/src/OptionButton.tsx:1
- [nitpick] For consistency with other components, place the React import (
import * as React from "react";) before third-party module imports likeclassnames.
import cx from "classnames";
packages/Metric/src/Metric.tsx:105
- The
QuestionIconcomponent is used here but not shown in the imports at the top of the file. Please add the appropriate import statement to avoid a runtime error.
<QuestionIcon size="sm" />
packages/Metric/src/Score.tsx:1
- [nitpick] Consider moving
import * as React from "react";above theclassnamesimport to align with the React-first import convention used in other components.
import cx from "classnames";
Victor Trinh (victortrinh2)
approved these changes
Jul 21, 2025
Patrick DeVries (PatrickDeVries)
deleted the
cleanup/EP-6630_clean-up-rebrand-e-through-p
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans up the rebrand styles and logic for components E-P.
The rebrand has been cleaned up in OV so the old brand styles are no longer relevant. They are also creating issues with OV's new RSBuild system and not behaving as expected.
For packages that have had a major release, I marked this a major bump. For packages that have not yet had a major release, I marked this a minor bump.