EP-6626: Clean up rebrand styles for components A-D#875
Merged
Patrick DeVries (PatrickDeVries) merged 13 commits intomainfrom Jul 21, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: be4cb1a The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for igloo-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes outdated, non-Workleap brand styles and logic for components A–D, simplifying SCSS and React code to only support the Workleap rebrand and updating package version bumps accordingly.
- Removed default CSS variable declarations in SCSS for multiple components, retaining only Workleap-specific overrides.
- Simplified component code by stripping out dynamic brand detection, defaulting to Workleap implementations.
- Updated snapshots and the changeset to reflect new icons, variable names, and version bumps.
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/Dropdown/src/mixins.scss | Dropped non-Workleap scrollbar variables |
| packages/Dropdown/src/dropdown.scss | Removed default dropdown variables, kept Workleap styles |
| packages/Disclosure/src/disclosure.scss | Cleared default disclosure variables, left Workleap specifics |
| packages/Dialog/src/dialog.scss | Removed default dialog variables and media queries, retaining Workleap vars |
| packages/Datepicker/src/datepicker.scss | Cleaned up default datepicker variables, kept Workleap cell sizing |
| packages/Combobox/src/combobox.scss | Deleted default combobox styling variables, kept Workleap overrides |
| packages/Combobox/src/combobox-input.scss | Removed default combobox-input variables, kept Workleap overrides |
| packages/Combobox/src/snapshots/Combobox.test.tsx.snap | Updated snapshot icon attributes and classes |
| packages/Combobox/src/ComboboxInput.tsx | Simplified imports and dropped dynamic brand logic |
| packages/ColorPicker/src/color-picker.scss | Removed default color-picker variables, retained Workleap styles |
| packages/ColorPicker/src/color-picker-option.scss | Cleared default option variables, kept Workleap border settings |
| packages/ColorPicker/src/snapshots/ColorPicker.test.tsx.snap | Updated snapshot data attributes and style variables |
| packages/ColorPicker/src/ColorPicker.tsx | Streamlined color locale logic, default to Workleap options |
| packages/ColorPicker/src/ColorPicker.test.tsx | Adjusted tests to use unified colorNames array and default selection |
| packages/Color/src/color.scss | Removed unused base color variables, kept Workleap border-radius |
| packages/Checkbox/src/checkbox.scss | Deleted default checkbox variables, left Workleap overrides |
| packages/Carousel/src/carousel.scss | Cleared default carousel variables, retained Workleap font settings |
| packages/Card/src/card.scss | Removed default card variables, kept Workleap typography |
| packages/ButtonGroup/src/button-group.scss | Deleted default button-group variables, left Workleap defaults |
| packages/Button/src/button.scss | Removed default button styling variables, kept Workleap styles |
| packages/Breadcrumb/src/breadcrumb.scss | Cleared default breadcrumb styles, left Workleap-specific rules |
| packages/BarChart/src/bar-chart.scss | Removed default bar-chart variables, retained Workleap font settings |
| packages/Avatar/src/avatar.scss | Deleted default avatar variables, kept Workleap border settings |
| packages/AreaChart/src/chart-tooltip.scss | Cleared default chart-tooltip variables, retained Workleap styles |
| packages/AreaChart/src/area-chart.scss | Removed default area-chart variables, kept Workleap font settings |
| packages/Alert/src/alert.scss | Deleted non-Workleap alert variables and legacy decorations |
| packages/Alert/src/snapshots/Alert.test.tsx.snap | Updated SVG snapshot paths and dimensions |
| packages/Alert/src/Alert.tsx | Simplified Alert component, removed brand detection and legacy icons |
| packages/ActionMenu/src/action-menu.scss | Deleted default action-menu variables, kept Workleap overrides |
| .changeset/mighty-years-smile.md | Bumped package versions post-rebrand cleanup |
Comments suppressed due to low confidence (3)
packages/Combobox/src/ComboboxInput.tsx:6
- The DismissIcon is imported here but not used in this component; consider removing it to avoid unused imports.
import { AngleDownIcon, AngleUpIcon, DismissIcon } from "@hopper-ui/icons-react16";
packages/Combobox/src/ComboboxInput.tsx:11
- VisualIdentifier is imported but never used in this file; you can remove this import to clean up unused code.
import { VisualIdentifier } from "@shared/components";
packages/Combobox/src/ComboboxInput.tsx:67
- Both chevronUpIcon and chevronDownIcon are defined but never used in this component; consider removing these unused variables.
const chevronUpIcon = <AngleUpIcon className={chevronClass} size="sm" />
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ov-igloo-ui\ into cleanup/EP-6626_clean-up-rebrand-a-through-d
…ov-igloo-ui\ into cleanup/EP-6626_clean-up-rebrand-a-through-d
…ov-igloo-ui\ into cleanup/EP-6626_clean-up-rebrand-a-through-d
Victor Trinh (victortrinh2)
approved these changes
Jul 21, 2025
Patrick DeVries (PatrickDeVries)
deleted the
cleanup/EP-6626_clean-up-rebrand-a-through-d
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans up the rebrand styles and logic for components A-D.
The rebrand has been cleaned up in OV so the old brand styles are no longer relevant. They are also creating issues with OV's new RSBuild system and not behaving as expected.
For packages that have had a major release, I marked this a major bump. For packages that have not yet had a major release, I marked this a minor bump.