-
Notifications
You must be signed in to change notification settings - Fork 57
Improve avoid-jitpack workflow #2264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The remaining work on this is to figure out a way to include all of the relevant js, css, scss files (any others?) in the task's input so that if any of them change the bundle is regenerated. This worries me because it seems very fragile and when it fails it will not be obvious that the reuse of a previously generated bundle is the problem. 🤔 This is making me think we may be better off publishing the artifacts ourself for devs who are not building Gutenberg from source (i.e., basically create our own Jitpack). |
Pushed an update that I think addresses that. (6d63c07) Its a bit hacky though, and I'm still concerned about this being fragile. Remaining things I think should be addressed:
|
|
In trying to make clean rerun the task I've realized that for some reason my task is not actually checking the output the way I thought it was. I can delete the bundle and the |
|
Just added fc9fbdb, which moves the bundle to the build folder and also has the |
cameronvoell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested via wordpress-mobile/WordPress-Android#11921. Looks good! ![]()
Now running `clean` will delete the current js bundle and the next build will know to generate a new one.
In the effort to fix the "Couldn't follow symbolic link." issue reported here: wordpress-mobile/WordPress-Android#11921 (comment)
883d9b9 to
7556716
Compare
Did another round of checks after retargeting and rebase with release branch. Looks good! |
Trying to improve the avoid-jitpack workflow, particularly the build speeds.
See WPAndroid PR for testing instructions
PR submission checklist:
RELEASE-NOTES.txtif necessary.