Gutenberg/embedded build no jitpack #11896

SergioEstevao · 2020-05-12T09:34:43Z

Stop using jitpack

To test:

1
- wp.BUILD_GUTENBERG_FROM_SOURCE is false
- Run ./gradlew assembleVanillaRelease from the command line
2
- wp.BUILD_GUTENBERG_FROM_SOURCE is true
- Run ./gradlew assembleWasabiDebug from the command line

PR submission checklist:

I have considered adding unit tests where possible.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Internally, passing down a "jitpack" flag to emulate the nested gutenberg-mobile build, which behind the scenes uses Node and Yarn to install the needed gutenberg-mobile RN dependencies to build.

On CircleCI, the JS bundle is build by a dedicated job to avoid out of memory issues when doing it embedded in the gradle build.

To try and avoid the out of memory issue (exit code 137) that seems to be happening.

The gb-mobile JS bundle has already been built and shared as via a CircleCI attached workspace so, no need for the nested submodules that only contribute JS code anyway.

…r-db-update-script When upgrading from older version do not go through migration script steps.

…-open-external-link Fix crash on opening external url

peril-wordpress-mobile · 2020-05-12T09:34:48Z

	Warnings
⚠️	PR is missing at least one label.
⚠️	PR is not assigned to a milestone.

Generated by 🚫 dangerJS

# Conflicts: # .circleci/config.yml

peril-wordpress-mobile · 2020-05-12T09:36:54Z

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

peril-wordpress-mobile · 2020-05-12T09:47:31Z

You can test the changes on this Pull Request by downloading the APK here.

…ild-no-jitpack Build gutenberg-mobile locally without JitPack # Conflicts: # .circleci/config.yml

.circleci/config.yml

settings.gradle

together

mchowning · 2020-05-13T14:14:48Z

👋 @cameronvoell and @chipsnyder . I think I've resolved the issues you both observed in doing debug builds with the avoid-jetpack changes in #11893 . Would you care to give this PR a try?

chipsnyder · 2020-05-13T16:59:29Z

Ran through the following builds with no problem 🥳 🚀 Nice work!

BUILD_GUTENBERG_FROM_SOURCE set to false:

./gradlew assembleVanillaDebug
./gradlew assembleVanillaRelease
./gradlew assembleWasabiDebug
./gradlew assembleWasabiRelease

BUILD_GUTENBERG_FROM_SOURCE set to true:

./gradlew assembleVanillaDebug
./gradlew assembleVanillaRelease
./gradlew assembleWasabiDebug
./gradlew assembleWasabiRelease

chipsnyder

Test results here: #11896 (comment)

cameronvoell · 2020-05-13T19:06:04Z

👋 @cameronvoell and @chipsnyder . I think I've resolved the issues you both observed in doing debug builds with the avoid-jetpack changes in #11893 . Would you care to give this PR a try?

Same results as Chip here #11896 (comment) Looks good!

mchowning · 2020-05-14T12:25:49Z

👋 @hypest ! I added a couple of changes on top of yours here. Would appreciate it if you could take a look since you're the most familiar with this.

We were having issues building from source with these changes because we need to not build the JSBundle when building from source, so in aca31b1 I updated the buildGutenbergMobileJSBundle variable to insure that it was never true if wp.BUILD_GUTENBERG_FROM_SOURCE is true.
There were some CI failures on the "Ensure Assets Folder Existsstage because we were trying to create the assets folder, but CI reported that the folder already existed. I updated the commands frommkdirtomkdir -p` to avoid this in 2e91423.

…is missing

hypest · 2020-05-18T09:11:46Z

I think the no-jitpack solution was merged to develop via #11921 so, not sure if this PR is needed anymore?

SergioEstevao · 2020-05-18T13:05:32Z

I don't think we need this PR now that the release branch was merged back to develop.
Closing it for now, if we need to have something from this branch we can cherry-pick later on.

hypest and others added 30 commits May 8, 2020 01:44

Build gutenberg-mobile locally, without JitPack

c2bd1b2

Internally, passing down a "jitpack" flag to emulate the nested gutenberg-mobile build, which behind the scenes uses Node and Yarn to install the needed gutenberg-mobile RN dependencies to build.

Rename flag to better reflect its purpose

0b4dea7

Perform git submodule checkout on CircleCI

1999670

Exclude gutenberg-mobile from checkstyle

5ab10b6

Try lifting the parallel gradle execution flag

37cd608

Update gb-mobile hash

7d4f79e

Have a dedicated CircleCI job to build JS bundle

b313cd3

Fix config error

d4291eb

Move working_directory directive inside the commands

2fdbc92

Remove unneeded command definition

58df58e

Correct path to lock file for cache key computation

23286cf

Correct path to generated JS bundle

11dabd8

Correct path to yarn install data to cache

514d673

Correct path to root path to persist

5c8ce70

Attach built JS artifact to all build jobs

19a16a0

Update gb-mobile hash to fix styling issues

c0db18c

Ignore gutenberg-mobile lint errors, not yet fixed

3a7514f

Bump gb-mobile hash to suppress lint errors on react-native-aztec

f498448

Fix erroneous local paths in lint-baseline

0277ce3

The hermes binaries are picked up from the gb-mobile build now

cf972ee

Default to building the JS bundle but not on CircleCI

bc509b3

On CircleCI, the JS bundle is build by a dedicated job to avoid out of memory issues when doing it embedded in the gradle build.

Try running the test job without gradle daemon

c4c9f8d

To try and avoid the out of memory issue (exit code 137) that seems to be happening.

Manually add the suppression flag in the gradle command line

376eca5

Explicitly specify JVM arguments in gradle command for circle ci tests

4140cf8

Rely on the JVS settings in gradle.properties-example

144093d

Reinstate parallel flag in gradle

610239f

No need to pull nested gb-mobile submodules on CI

c05efbc

The gb-mobile JS bundle has already been built and shared as via a CircleCI attached workspace so, no need for the nested submodules that only contribute JS code anyway.

Update gb-mobile hash, pointing to its master

e0f5444

Add FLAG_ACTIVITY_NEW_TASK for intent to open external url

9e925bb

When upgrading from older version do not go through update script steps.

9d47b58

malinajirka and others added 2 commits May 12, 2020 09:45

Merge pull request #11885 from wordpress-mobile/issue/11845-fix-reade…

3b64b0c

…r-db-update-script When upgrading from older version do not go through migration script steps.

Merge pull request #11873 from wordpress-mobile/issue/11820-fix-crash…

47cb966

…-open-external-link Fix crash on opening external url

SergioEstevao requested review from dratwas and maxme May 12, 2020 09:34

Merge branch 'develop' into gutenberg/embedded-build-no-jitpack

dae4828

# Conflicts: # .circleci/config.yml

hypest added 2 commits May 12, 2020 10:54

Bump gb-mobile hash with merged JS bundles

20c94ed

Merge pull request #11833 from wordpress-mobile/gutenberg/embedded-bu…

1faee8d

…ild-no-jitpack Build gutenberg-mobile locally without JitPack # Conflicts: # .circleci/config.yml

dratwas reviewed May 12, 2020

View reviewed changes

.circleci/config.yml Show resolved Hide resolved

dratwas reviewed May 12, 2020

View reviewed changes

settings.gradle Show resolved Hide resolved

SergioEstevao changed the base branch from develop to gutenberg/after_1.28.0 May 12, 2020 14:26

mchowning force-pushed the gutenberg/embedded-build-no-jitpack branch from 5d1a9c5 to 1faee8d Compare May 12, 2020 22:25

mchowning added 2 commits May 13, 2020 09:01

Prevent CI from failing if directories already exist

2e91423

Insure BUILD_GUTENBERG_FROM_SOURCE and buildGutenbergMobileJSBundle work

aca31b1

together

mchowning force-pushed the gutenberg/embedded-build-no-jitpack branch from 9802254 to aca31b1 Compare May 13, 2020 13:01

chipsnyder approved these changes May 13, 2020

View reviewed changes

cameronvoell self-requested a review May 13, 2020 19:05

Clarify error message when building gb from source with node_modules …

0fe4e03

…is missing

mchowning mentioned this pull request May 15, 2020

Gutenberg/no jitpack updates to gutenberg 1.28 branch #11921

Merged

3 tasks

dratwas approved these changes May 18, 2020

View reviewed changes

SergioEstevao closed this May 18, 2020

SergioEstevao deleted the gutenberg/embedded-build-no-jitpack branch May 18, 2020 13:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gutenberg/embedded build no jitpack #11896

Gutenberg/embedded build no jitpack #11896

Uh oh!

SergioEstevao commented May 12, 2020 •

edited by mchowning

Loading

Uh oh!

peril-wordpress-mobile bot commented May 12, 2020 •

edited

Loading

Uh oh!

peril-wordpress-mobile bot commented May 12, 2020 •

edited

Loading

Uh oh!

peril-wordpress-mobile bot commented May 12, 2020 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

mchowning commented May 13, 2020

Uh oh!

chipsnyder commented May 13, 2020

Uh oh!

chipsnyder left a comment

Uh oh!

cameronvoell commented May 13, 2020

Uh oh!

mchowning commented May 14, 2020

Uh oh!

hypest commented May 18, 2020

Uh oh!

SergioEstevao commented May 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Gutenberg/embedded build no jitpack #11896

Gutenberg/embedded build no jitpack #11896

Uh oh!

Conversation

SergioEstevao commented May 12, 2020 • edited by mchowning Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peril-wordpress-mobile bot commented May 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peril-wordpress-mobile bot commented May 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peril-wordpress-mobile bot commented May 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mchowning commented May 13, 2020

Uh oh!

chipsnyder commented May 13, 2020

Uh oh!

chipsnyder left a comment

Choose a reason for hiding this comment

Uh oh!

cameronvoell commented May 13, 2020

Uh oh!

mchowning commented May 14, 2020

Uh oh!

hypest commented May 18, 2020

Uh oh!

SergioEstevao commented May 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

SergioEstevao commented May 12, 2020 •

edited by mchowning

Loading

peril-wordpress-mobile bot commented May 12, 2020 •

edited

Loading

peril-wordpress-mobile bot commented May 12, 2020 •

edited

Loading

peril-wordpress-mobile bot commented May 12, 2020 •

edited

Loading