Skip to content

Conversation

@luislard
Copy link
Contributor

@luislard luislard commented Apr 28, 2021

Fixes #57

The background in the container is determined by the background of the theme.
See:

storefront/inc/customizer/class-storefront-customizer.php:1009
image

image

This issue is repeated in other themes like boutique. See: woocommerce/boutique#81

General question -> Why not fix the source of the problem? why not delegate the responsabily of this background to the woo products blocks plugin?
https://github.com/woocommerce/woocommerce-gutenberg-products-block

This PR harcodes the background color to #EAEAEA

Screenshots

How to test the changes in this Pull Request:

Changelog

Hardcodes the background to #EAEAEA

Tests

@nerrad
Copy link
Contributor

nerrad commented May 3, 2021

I think you could take a similar approach to the comment I made here which has the advantage of still allowing users to modify this color in the customizer.

Why not fix the source of the problem? why not delegate the responsabily of this background to the woo products blocks plugin?

Can you elaborate on why you think Woo Blocks is the source of the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lighten background color for payment method icons in the Cart block

4 participants