Skip to content

Conversation

@rcombs
Copy link

@rcombs rcombs commented Jul 10, 2020

This is derived from #72, but with the commits restructured and simplified, and some additional changes.

  • Fix building on MSVC
    • Fix incorrect static array size
    • Remove implicit type conversions
    • Remove VLA usage
  • Expose a thread-safe version of the main hash function

The original main hash function is now implemented in terms of the thread-safe version.

@mrousavy
Copy link
Contributor

mrousavy commented Aug 4, 2020

Does this come with a performance cost?

@rcombs
Copy link
Author

rcombs commented Aug 4, 2020

A small one, but yes; you could alternately solve the same problem by making the array [9][9][3] at no cost.

@jerry-git jerry-git added C enhancement New feature or request labels Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants