Fix suspected off-by-one error in Swift decoder #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and bottom edges of decoded BlurHash images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe I found an off-by-one error in the Swift decoder that was resulting in detail being cropped from the bottom and right edges of the decoded images.
Because the
xandypixel coordinates are iterated using half-open ranges, their maximum values are one less thanwidthandheight. Therefore I think the divisors for calculating thebasiswhen iterating over pixels should also be one less.This isn’t very noticeable when using the recommended 32x32 size, but when using smaller sizes like 8x8, this change makes the BlurHash images line up more closely with their source images.