Skip to content

Add note about stimulus-blurhash #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bb wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add note about stimulus-blurhash #194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TypeScript/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
npm install --save blurhash
```

See [react-blurhash](https://github.com/woltapp/react-blurhash) to use blurhash with React.
See [react-blurhash](https://github.com/woltapp/react-blurhash) to use blurhash with React or [stimulus-blurhash](https://github.com/bb/stimulus-blurhash) to use it with Hotwire Stimulus.
Copy link
Contributor

@Thisen Thisen Feb 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this implementation should be listed under implementations in README!

Copy link
Author

@bb bb Feb 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can of course add both react-blurhash and stimulus-blurhash to the global README. However, neither of those are actual implementations. They both have the TypeScript implementation as a dependency. So I'd add both react-blurhash and stimulus-blurhash as sub-bullets of the TypeScript implementation? Or would you prefer somewhere else?


## API

Expand Down