Support building cross arch via qemu #52630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoser
force-pushed
the
feat/qemu-multi-arch
branch
from
e01cc48 to
9474281
Compare
The qemu runner "just works" for cross arch, you just have
to supply it a target-arch kernel. So the changes here really
only amount to creating kernel/<ARCH>/vmlinuz rather than
kernel/vmlinuz.
Now, tested inside a 'make dev-container' environment and also
on an x86_64 Ubuntu 24.04 host, I can:
make MELANGE_RUNNER=qemu ARCH=aarch64 debug/dash
And then also:
make MELANGE_RUNNER=qemu ARCH=aarch64 test/dash
smoser
force-pushed
the
feat/qemu-multi-arch
branch
from
9474281 to
3bb8361
Compare
Member
Author
|
Related chainguard-dev/melange#1970 |
dannf
reviewed
May 6, 2025
Member
|
This is sweet! Thanks for banging this out so quickly! |
Member
|
Works for me here on a Linux machine. Would be great if someone could try this from a Mac and see if it can cross-compile x86 as well? |
Member
|
Tested on my Mac seems to be working fine |
justinvreeland
previously approved these changes
May 7, 2025
QEMU_KERNEL_DEP should be added to the test deps so you can just 'make MELANGE_RUNNER=qemu test/dash' without having to first 'make fetch-kernel'. Second thing here is a fix to verify that a 'vmlinuz' is created by the tar extraction. Without that change if the apk did not contain boot/vmlinuz, we'd created it with 'touch'
justinvreeland
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The qemu runner "just works" for cross arch, you just have to supply it a target-arch kernel. So the changes here really only amount to creating kernel//vmlinuz rather than kernel/vmlinuz.
Now, tested inside a 'make dev-container' environment and also on an x86_64 Ubuntu 24.04 host, I can:
And also: