Draft
Conversation
miniBill
force-pushed
the
dont-skip-paths
branch
from
6d9ac03 to
603ee6c
Compare
Collaborator
Author
|
This will need #275 before CI passes, we can wait on merging until it's green |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skipping ungenerable paths made sense when we had a lot of holes in our coverage, but I think it's time to switch to fail-by-default, while keeping the option to keep going on failed paths.
Eventually we probably want this option to go away, when we're confident we're covering most of the spec.