Skip to content

password string format#266

Merged
wolfadex merged 1 commit intomainfrom
password-format
Feb 3, 2026
Merged

password string format#266
wolfadex merged 1 commit intomainfrom
password-format

Conversation

@miniBill
Copy link
Collaborator

@miniBill miniBill commented Feb 3, 2026

This is a standard format that just signals UIs to asterisk values, but doesn't change them

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

diff --ignore-all-space --minimal --new-file --recursive main/cli/generated/OpenApi/Common.elm branch/cli/generated/OpenApi/Common.elm
2,4c2,4
<     ( encodeStringDate, encodeStringDateTime, encodeStringUri, encodeStringUuid, toParamStringStringDate, toParamStringStringDateTime
<     , toParamStringStringUri, toParamStringStringUuid
<     , decodeStringDate, decodeStringDateTime, decodeStringUri, decodeStringUuid
---
>     ( encodeStringDate, encodeStringDateTime, encodeStringPassword, encodeStringUri, encodeStringUuid, toParamStringStringDate
>     , toParamStringStringDateTime, toParamStringStringPassword, toParamStringStringUri, toParamStringStringUuid
>     , decodeStringDate, decodeStringDateTime, decodeStringPassword, decodeStringUri, decodeStringUuid
15,16c15,16
< @docs encodeStringDate, encodeStringDateTime, encodeStringUri, encodeStringUuid, toParamStringStringDate, toParamStringStringDateTime
< @docs toParamStringStringUri, toParamStringStringUuid
---
> @docs encodeStringDate, encodeStringDateTime, encodeStringPassword, encodeStringUri, encodeStringUuid, toParamStringStringDate
> @docs toParamStringStringDateTime, toParamStringStringPassword, toParamStringStringUri, toParamStringStringUuid
21c21
< @docs decodeStringDate, decodeStringDateTime, decodeStringUri, decodeStringUuid
---
> @docs decodeStringDate, decodeStringDateTime, decodeStringPassword, decodeStringUri, decodeStringUuid
65a66,70
> encodeStringPassword : String -> Json.Encode.Value
> encodeStringPassword =
>     Json.Encode.string
> 
> 
88a94,98
> toParamStringStringPassword : String -> String
> toParamStringStringPassword value =
>     value
> 
> 
126a137,141
> 
> 
> decodeStringPassword : Json.Decode.Decoder String
> decodeStringPassword =
>     Json.Decode.string
diff --ignore-all-space --minimal --new-file --recursive main/cli/generated/RealworldConduitApi/Json.elm branch/cli/generated/RealworldConduitApi/Json.elm
97c97
<         , ( "password", Json.Encode.string rec.password )
---
>         , ( "password", OpenApi.Common.encodeStringPassword rec.password )
156c156
<         , ( "password", Json.Encode.string rec.password )
---
>         , ( "password", OpenApi.Common.encodeStringPassword rec.password )
419c419
<                 Json.Decode.string
---
>                 OpenApi.Common.decodeStringPassword
538c538
<                 Json.Decode.string
---
>                 OpenApi.Common.decodeStringPassword

@miniBill
Copy link
Collaborator Author

miniBill commented Feb 3, 2026

Alternatively, we could have a type Password = Password String to be more explicit?

@wolfadex wolfadex merged commit 81546d9 into main Feb 3, 2026
2 checks passed
@wolfadex wolfadex deleted the password-format branch February 3, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants