Open
Conversation
- Since the root project is now an Elm package, all code it needs must be in its src folder. (Packages don't support `source-directories`.) - Add package's src folder to the CLI's `elm.json`.
312c443 to
6f6261a
Compare
We're splitting up the Cli.elm file into two pieces, and that means we'll lose history for one of them. So let's preserve the git history of the bigger piece, the code that will now live in OpenApi.BackendTask.
6f6261a to
722866d
Compare
The previously installed version had a bug where it required you to install Vite yourself for its use.
577c885 to
5afec96
Compare
Contributor
Author
|
Sorry for the force-pushes! The first was to fix a bug (I'd used a slightly outdated The second was to preserve git history for The third was to upgrade elm-pages rather than re-install |
Collaborator
|
Force pushes are fine in branches, no worries 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version is factored into logical commits(!).
Unlike the first version of this effort, this one does not use any tricks to make Elm think the local package is a real package; it just uses
source-directoriesfor that (and is careful about not having anyGen.modules in the example project, in order to avoid name collisions).CAVEATS: