Identify project bundle by checking for build.properties rather than .project nature #1031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugithordarson
changed the title
hugithordarson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means
ERXApplication$Loaderwill check for abuild.propertiesfile in classpath entries to see if it's a ProjectBundle, rather than looking for an Eclipse.projectfile and checking if it contains a WOLips nature. This almost makes the content of WOLips'.projectfile redundant for Project Wonder to work with bundleless builds.(the one remaining step is to make Wonder completely non-dependent on
.projectis a fix in ERFoundation — #1030)