#1025 Proposed fix for bundleless maven app builds #1026
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Encountering odd behaviour after doing some more testing. Closing this pull request for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in #1025. The error occurred because
NSBundle.Classpathwasnullin the check I disabled, meaningmainBundle()skipped bundle initialization and returned null. If the check is disabled, a simple test maven application seemingly runs fine using bundleless builds. Why this check is there, I don't know, why it specifically fails with maven builds I have no idea. Added in this commit:c4d9ccf
My initial guess is that it's meant to check if the main bundle has been successfully initialized, so I initially thought bypassing it like this might mean we end up with an incompletely initialized bundle. But I don't see anything wrong with the main bundle when the application is up and running.
Since I don't have any actual complex-ish Wonder apps to do further testing on, someone more capable should probably review this and try it out.