Skip to content

Comments

refactor: initialise logger on boot so it can be used anywhere in Tym…#586

Open
meenahoda wants to merge 3 commits intomasterfrom
core-logger
Open

refactor: initialise logger on boot so it can be used anywhere in Tym…#586
meenahoda wants to merge 3 commits intomasterfrom
core-logger

Conversation

@meenahoda
Copy link
Member

…ly and able to override with plugins

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

❌ Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.38%. Comparing base (d3bfda6) to head (1feb02e).
⚠️ Report is 252 commits behind head on master.

Files with missing lines Patch % Lines
lib/logger-service/index.js 60.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (d3bfda6) and HEAD (1feb02e). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (d3bfda6) HEAD (1feb02e)
3 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #586       +/-   ##
===========================================
- Coverage   90.58%   72.38%   -18.21%     
===========================================
  Files          76       77        +1     
  Lines        1731     1738        +7     
===========================================
- Hits         1568     1258      -310     
- Misses        163      480      +317     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@meenahoda meenahoda marked this pull request as ready for review April 4, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant