wip: Generalize authorize function, add file and role operations#89
Open
naugtur wants to merge 1 commit intowmfs:masterfrom
Open
wip: Generalize authorize function, add file and role operations#89naugtur wants to merge 1 commit intowmfs:masterfrom
naugtur wants to merge 1 commit intowmfs:masterfrom
Conversation
naugtur
commented
Jul 7, 2020
| throw new Error('You must provide a username and password.') | ||
| async authenticate (credentials) { | ||
| if (!credentials) { | ||
| throw Error('Credentials are required') |
Author
There was a problem hiding this comment.
I removed all new before Error because it doesn't do anything in Javascript really other than creating an unnecessary object in memory maybe.
Author
|
Hi, I needed much more features related to sharing and permissions, so I switched to pnpjs. Feel free to merge just parts of it. I'd recommend removing the roles functionality and merging the rest if you don't want to continue the work on roles. |
Contributor
|
No worries 👍 Thanks for your work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any tips from people who know sharepoint would help.
I need to set single file permissions to single users and have no idea how to proceed yet :)