Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

Enable testing the Dialog component on IE11 #524

Open
chukarave wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enable testing the Dialog component on IE11 #524

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
047536e
remove code to disable testig the Dialog component on IE11
chukarave Jan 14, 2022
9cb8308
Merge branch 'master' into enable-IE-browser-tests
sai-san Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions vue-components/tests/e2e/specs/Dialog.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,6 @@ describe( 'Dialog', function () {
} );

it( 'traps page focus, so that only visually focused elements are tab-able', function ( client ) {
const currentBrowser = client.options.desiredCapabilities.browserName;

if ( currentBrowser === 'internet explorer' ) {
return; // https://phabricator.wikimedia.org/T298238
}
client
.click( '.wikit-Button' )
.pause( 500 )
Expand Down Expand Up @@ -60,10 +55,6 @@ describe( 'Dialog', function () {
} );

it( 'prevents underlying page from scrolling when opened and on initial render', function ( client ) {
if ( client.options.desiredCapabilities.browserName === 'internet explorer' ) {
return; // https://phabricator.wikimedia.org/T298238
}

client
.execute( 'document.body.style.height = "150vh";' )
.execute( 'window.scrollTo( 0, document.body.scrollHeight );' )
Expand All @@ -80,10 +71,6 @@ describe( 'Dialog', function () {
} );

it( 'resets dialog scroll bars to top when closed and reopened', function ( client ) {
if ( client.options.desiredCapabilities.browserName === 'internet explorer' ) {
return; // https://phabricator.wikimedia.org/T298238
}

client
.click( '.wikit-Button' )
.pause( 500 )
Expand Down