Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I haven't updated this project in a minute. Lute has made a ton of breaking changes
This PR makes minimum viable changes, to get the project working with Lute latest. It is quite messy, and the brittleness of the project against Lute changes is something I need to better address in the long term.
Solution
Align with latest Lute API
Remove some redundancies
Attempt to fix tests / broken logic
I am merging simply so we get an updated version out, with much follow up work needed
Future Work
Better robustness to lute changes
Less hard-coded shit
Remove more redundancies that we can handle with new Lute APIs