wire-protocol: Send buffer data in-line below a certain size#35
Open
wire-protocol: Send buffer data in-line below a certain size#35
Conversation
Add caps property that allows the src to easily negotiate a format.
Here we make things match the GStreamer model a bit better. Our payloader
payloads the caps too so before it's:
video/x-raw,format=BGR
and after it's
application/x-fd,payloaded-name=video/x-raw,format=BGR
and vice-versa for the depayloader. We're now communicating the payloaded
caps over DBus rather than the payloaded ones.
This way we can set the caps on the socketsrc, rather than having them
applied after the payloader using a capsfilter. They will travel
downstream synchronised with the data.
This fits better with the GStreamer model and will make implementing
fddepay as a `GstBaseParse` possible. Without this we don't know how to
set caps on the fddepay srcpad and GstBaseParse throws an error.
We're looking to send small buffers directly over the socket, rather than with FD payloading. GstBaseParse is the appropriate base class for this as it allows splitting and concatenating buffers.
Below a certain size it's faster to copy the data than it is to use `mmap`. This will make pulsevideo more efficient for audio and encoded video data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Below a certain size it's faster to copy the data than it is to use
mmap.This will make pulsevideo more efficient for audio and encoded video data.