Fix decompression of files with multiple frames.#12
Open
DiThi wants to merge 1 commit intowltsmrz:developfrom
Open
Fix decompression of files with multiple frames.#12DiThi wants to merge 1 commit intowltsmrz:developfrom
DiThi wants to merge 1 commit intowltsmrz:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decompressing a file with more than one frame fails with the message "Destination buffer is too small". This is because
ZSTD_getFrameContentSizeonly gives the size of the first frame.The solution is to use
ZSTD_findDecompressedSize. However, it is in a section of the header that is disabled when not usingZSTD_STATIC_LINKING_ONLY. To avoid having to define it I just addedcdecl, so nim makes the declaration instead of just using it.