Hotspot reports under long wavelength approximation. We use an adapte… #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d 2D version of PIC architecture due to F. Huang (2011)
Owner
|
The results are very nice, but I don't think they belong to a repository. In particular, the movies are binaries and large, so it might be inconvenient to force future users or collaborators to download them together with the package. |
Contributor
|
Maybe it would make most sense for @guillepo to put them in their own repo, and to PR a reference to that repo on this one's docs. That could even be adjusted to use my promised "repro" script for easy consumption! By the way @wlmb could you release an updated Photonic with the metadata etc from Also, are you interested in a PR updating this to use PDLA? That would need me to port FFTW3 etc as well but that should be easy. |
Owner
|
On Mon, May 06, 2019 at 06:11:23PM +0000, mohawk2 wrote:
Maybe it would make most sense for @guillepo to put them in their own repo, and to PR a reference to that repo on this one's docs.
I agree.
That could even be adjusted to use my promised "repro" script for easy consumption!
By the way @wlmb could you release an updated Photonic with the metadata etc from `master`?
My plan is to finish the reorganization of the package (currently in
branch devel-factory, a misnomer), add some documentation (although I guess not
exhaustive yet), merge with master and then upload to cpan. It should take
a few days.
Also, are you interested in a PR updating this to use PDLA? That would need me to port FFTW3 etc as well but that should be easy.
Yes!
Best regards and thanks for your interest,
Luis
…--
o
W. Luis Mochán, | tel:(52)(777)329-1734 /<(*)
Instituto de Ciencias Físicas, UNAM | fax:(52)(777)317-5388 `>/ /\
Apdo. Postal 48-3, 62251 | (*)/\/ \
Cuernavaca, Morelos, México | mochan@fis.unam.mx /\_/\__/
GPG: 791EB9EB, C949 3F81 6D9B 1191 9A16 C2DF 5F0A C52B 791E B9EB
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d 2D version of PIC architecture due to F. Huang (2011)