[GUI] display wallet birthday#943
Open
pythcoiner wants to merge 1 commit intowizardsardine:masterfrom
Open
Conversation
Collaborator
Author
|
should I display date as MM/DD/YY, as it can be confusing to some european country that use DD/MM/YY? |
pythcoiner
commented
Jan 29, 2024
pythcoiner
force-pushed
the
wallet_birthday_gui2
branch
from
37e3888 to
475fc11
Compare
pythcoiner
changed the title
darosior
reviewed
Feb 6, 2024
pythcoiner
force-pushed
the
wallet_birthday_gui2
branch
from
475fc11 to
5846fe3
Compare
pythcoiner
force-pushed
the
wallet_birthday_gui2
branch
from
e7b7fda to
6160735
Compare
Collaborator
Author
|
comments have been adressed |
Member
|
Just to give an update on this, it's being stuck because we had a disagreement (Kevin and i) about how this should be displayed to the user. I'm not sure where this landed though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #805