[WIP] Payjoin receiver by benalleng · Pull Request #2011 · wizardsardine/liana

benalleng · 2026-02-10T15:05:48Z

This adds support for payjoin receive in liana.

This is currently WIP and has the following TODOs

Move bip21 to be created at runtime instead of at the time of receiver creation in lianad allowing us to not need to store bip21
Ensure that the expiry is properly handled as it currently panics when an incomplete session expires

lianad/src/database/sqlite/schema.rs

lianad/src/database/sqlite/utils.rs

xstoicunicornx

I know this is still a WIP and my comments may be a bit premature but just wanted to brain dump some of the notes I took as part of the BOSS Payjoin Showcase session.

Some additional general comments:

should amount be added to URI?
should adjusting expiration will be added to settings?
when I ran this PR Liana panicked with this error when I tried to send a payjoin to the receiver:2026-04-09T16:19:40.194941Z ERROR liana_gui:82: panic occurred at line 508 of file lianad/src/database/sqlite/mod.rs: Some("database must be available: SqliteFailure(Error { code: Unknown, extended_code: 1 }, Some(\"table payjoin_outpoints has no column named added_at\"))") 0: backtrace::backtrace::libunwind::trace
in the GUI when payjoin is listed under previously generated addresses it shows the address rather than URI (I'm guessing this is related to this comment)

xstoicunicornx · 2026-04-09T16:33:09Z

lianad/src/commands/mod.rs

+        let bip21 = session.pj_uri().to_string();
+
+        let mut db_conn = self.db.connection();
+        db_conn.update_payjoin_receiver_bip21(new_index.into(), &bip21);


Since this is now no-op this call is probably no longer needed?

xstoicunicornx · 2026-04-09T16:34:56Z

lianad/src/commands/mod.rs

+        Ok(GetAddressResult::new(address, new_index, Some(bip21)))
+    }
+
+    /// Get Payjoin URI (BIP21) and its sender/receiver status by txid


Suggested change

/// Get Payjoin URI (BIP21) and its sender/receiver status by txid

/// Get receiver session ID and its sender/receiver status by txid

xstoicunicornx · 2026-04-09T16:40:32Z

lianad/src/commands/mod.rs

+    }
+
+    /// Get all active payjoin receiver sessions with their derivation indexes
+    pub fn get_active_payjoin_sessions(&self) -> Result<Vec<u32>, CommandError> {


I believe that the plan is to also support sending payjoin in liana correct? Should this fn name maybe be get_active_receiver_payjoin_sessions instead to remove ambiguity in future when there may also be active payjoin sender sessions?

xstoicunicornx · 2026-04-09T16:48:23Z

lianad/src/database/sqlite/schema.rs

+/* Payjoin OHttpKeys */
+CREATE TABLE payjoin_ohttp_keys (
+    id INTEGER PRIMARY KEY NOT NULL,
+    relay_url TEXT UNIQUE NOT NULL,


Should this be the payjoin directory url instead? Aren't OHttpKeys specific to a payjoin directory, not relay?

If sopayjoin_save_ohttp_keys and payjoin_get_ohttp_keys also would need to be updated.

xstoicunicornx · 2026-04-09T16:55:31Z

lianad/src/database/sqlite/mod.rs

+    }
+
+    /// Get bip21 for a receiver session by derivation index
+    pub fn get_payjoin_receiver_bip21(&mut self, derivation_index: u32) -> Option<String> {


This seems to just return a normal address and not a bip21?

xstoicunicornx · 2026-04-09T16:59:29Z

lianad/src/payjoin/helpers.rs

+    }
+}
+
+pub(crate) fn fetch_ohttp_keys(


Is it possible to reuse PDK's implementation of fetch_ohttp_keys?

xstoicunicornx · 2026-04-09T17:00:31Z

lianad/src/payjoin/receiver.rs

+    db_conn: &mut Box<dyn DatabaseConnection>,
+    secp: &secp256k1::Secp256k1<secp256k1::VerifyOnly>,
+) -> Result<(), Box<dyn Error>> {
+    let proposal = proposal.apply_fee_range(None, None).save(persister)?;


No fee range actually being applied.

benalleng · 2026-04-09T19:31:43Z

Thanks for the feedback,

Regarding the UI notes.

should amount be added to URI?

Since it is not a mandatory addition in the payjoin spec I thought that for a desktop on-chain only wallet the UX of adding an amount on the receive side is sort of unfamiliar, especially given the current liana receiver UI

should adjusting expiration will be added to settings?

I think again perhaps this is worth some user research but with the ability to do a fallback tx at any point I am not sure that extending the expiration as an option is great to put in the user's direct control

in the GUI when payjoin is listed under previously generated addresses it shows the address rather than URI (I'm guessing this is related to this comment)

This was something we landed on due wanting to discourage reuse of payjoin sessions. I could share this bip21 with as many people as I want similar to address reuse but instead of just bad privacy you would get a bunch of payjoin failures

The method again is a holdout as the last time I gave this some serious focus I transitioned from storing the bip21 to the session ID directly and I previously wanted to have access to the bip21 in the db where I just generate it in the gui now and don't store it directly

benalleng · 2026-04-09T19:33:12Z

when I ran this PR Liana panicked with this error when I tried to send a payjoin to the receiver:2026-04-09T16:19:40.194941Z ERROR liana_gui:82: panic occurred at line 508 of file lianad/src/database/sqlite/mod.rs: Some("database must be available: SqliteFailure(Error { code: Unknown, extended_code: 1 }, Some("table payjoin_outpoints has no column named added_at"))") 0: backtrace::backtrace::libunwind::trace

This is definitely an artifact of me playing in the database between naming the timestamp added_at vs created_at https://github.com/wizardsardine/liana/pull/2011/changes#diff-4f33457fe83ad075401f91984457b7503d757068fcb26def0e090c584fd8439dR1146

yashrajd · 2026-04-10T19:48:55Z

should amount be added to URI?

Since it is not a mandatory addition in the payjoin spec I thought that for a desktop on-chain only wallet the UX of adding an amount on the receive side is sort of unfamiliar, especially given the current liana receiver UI

Familiarity might not be an issue IMO, since Liana users presumably also use other (esp mobile) wallets that have this. IMO it's more about the use case or user type: how often do they want to receive an specific exact amount? That said, this seems like a reasonable starting point.

should adjusting expiration will be added to settings?

I think again perhaps this is worth some user research but with the ability to do a fallback tx at any point I am not sure that extending the expiration as an option is great to put in the user's direct control

My hunch is, Liana users are likely to be sophisticated enough to use such a feature properly. Perhaps there could be appropriate messaging/guidance about using the feature.
From user research side, I'd say we have zero/little data to go on with, but you can always survey users to know their preferences (albeit with the "faster horse-carriages" caveat) (again without existing user base it is hard to rely on stated user preferences).

benalleng mentioned this pull request Feb 10, 2026

Add bip21 receive display support #1922

Closed

benalleng force-pushed the payjoin-receiver branch 4 times, most recently from 6c93104 to 943eb03 Compare February 20, 2026 19:58

benalleng mentioned this pull request Feb 23, 2026

Standup Input: Week of 2026-02-23 payjoin/rust-payjoin#1352

Closed

DanGould mentioned this pull request Feb 25, 2026

Liana x Payjoin Tracking Issue payjoin/rust-payjoin#1204

Open

5 tasks

arminsabouri reviewed Mar 3, 2026

View reviewed changes

lianad/src/database/sqlite/schema.rs Outdated Show resolved Hide resolved

lianad/src/database/sqlite/schema.rs Outdated Show resolved Hide resolved

lianad/src/database/sqlite/schema.rs Outdated Show resolved Hide resolved

lianad/src/database/sqlite/utils.rs Outdated Show resolved Hide resolved

benalleng force-pushed the payjoin-receiver branch from f24e841 to 00c9c51 Compare March 4, 2026 20:24

benalleng mentioned this pull request Mar 9, 2026

Standup Input: Week of 2026-03-09 payjoin/rust-payjoin#1396

Closed

benalleng force-pushed the payjoin-receiver branch 3 times, most recently from f39de07 to b6b17ff Compare March 10, 2026 13:40

Add payjoin dep in lianad

ffb8d18

benalleng force-pushed the payjoin-receiver branch from b6b17ff to f53d60a Compare March 10, 2026 13:49

benalleng marked this pull request as ready for review March 12, 2026 18:06

DanGould mentioned this pull request Mar 16, 2026

Standup Input: Week of 2026-03-16 payjoin/rust-payjoin#1417

Closed

benalleng force-pushed the payjoin-receiver branch from bf50b25 to 244c5df Compare March 17, 2026 15:27

Add payjoin support within lianad

5210c6c

benalleng force-pushed the payjoin-receiver branch from 244c5df to 31b32f6 Compare March 17, 2026 15:27

benalleng added 5 commits March 17, 2026 11:42

Minor adjustments in liana source

0c223f7

Add payjoin styles in ui framework

f1f7cda

WIP add payjoin to frontend

d7791b7

Update lock for payjoin addition

0ab1f5a

Add adjustable settings for payjoin server connections

44b658c

benalleng force-pushed the payjoin-receiver branch from 31b32f6 to 44b658c Compare March 17, 2026 15:42

benalleng added 2 commits March 17, 2026 12:30

fixup! Add adjustable settings for payjoin server connections

aaed3b6

Add payjoin specific test utils

93db05b

benalleng force-pushed the payjoin-receiver branch from f5ce076 to 93db05b Compare March 17, 2026 16:59

try fix for functional tests

da7ff64

benalleng force-pushed the payjoin-receiver branch from d0f60d0 to da7ff64 Compare March 18, 2026 20:06

xstoicunicornx reviewed Apr 9, 2026

View reviewed changes

	/// Get Payjoin URI (BIP21) and its sender/receiver status by txid
	/// Get receiver session ID and its sender/receiver status by txid

Conversation

benalleng commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xstoicunicornx left a comment

Choose a reason for hiding this comment

Uh oh!

xstoicunicornx Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

xstoicunicornx Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

xstoicunicornx Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

xstoicunicornx Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

xstoicunicornx Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

xstoicunicornx Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

xstoicunicornx Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

benalleng commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benalleng commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yashrajd commented Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

benalleng commented Feb 10, 2026 •

edited

Loading

benalleng commented Apr 9, 2026 •

edited

Loading

benalleng commented Apr 9, 2026 •

edited

Loading