remove address index from qr code#1965
Open
jp1ac4 wants to merge 1 commit intowizardsardine:masterfrom
Open
Conversation
The index is not required and should not be revealed.
Collaborator
|
FYI #1962 (comment) |
Collaborator
Author
|
As per the updates to #1962, I've kept this PR unchanged and any change to the verify modal can be done separately.. |
Collaborator
Note: we should not merge this PR until the change on the verify modal is done. |
Collaborator
Could you elaborate on why is that? |
Collaborator
because it'll cause a regression, the purpose of the index in th QR code there is to allow Specter users to verify their address (we dont have this implemented on USB), and just removing the index will break this |
nondiremanuel
modified the milestones:
v14 Liana - General fixes and improvements,
v15 Liana - Candidates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements #1962.