bhwi-cli(jade): fix serial transport reading#28
Merged
edouardparis merged 1 commit intowizardsardine:mainfrom Apr 13, 2026
Merged
bhwi-cli(jade): fix serial transport reading#28edouardparis merged 1 commit intowizardsardine:mainfrom
edouardparis merged 1 commit intowizardsardine:mainfrom
Conversation
- Fix bug where reading from the serial stream was hanging since it wasn't using cbor framed streaming. Didn't catch this cause I only checked with WASM and the emulator. - Refactored and renamed TcpClient trait to CborStream and implemented it for SerialTransport - Change PinServerClient HttpClient request header to be json for correctness
edouardparis
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cbor framed streaming. Didn't catch this cause I only checked with WASM and the
emulator.
SerialTransport
Fixes #27