bhwi-cli: add `descriptors pubkeys` command by trevarj · Pull Request #22 · wizardsardine/bhwi

trevarj · 2026-04-04T05:49:09Z

Analogous to Python HWI's getdescriptors.

Note: HWI uses h instead ' for the paths, so the checksums are different. This isn't possible right now with rust-miniscript

cargo r -- --format json descriptors pubkeys | jq
{
  "internal": [
    "pkh([0f056943/44'/0'/0']tpubDDpWvmUrPZrhSPmUzCMBHffvC3HyMAPnWDSAQNBTnj1iZeJa7BZQEttFiP4DS4GCcXQHezdXhn86Hj6LHX5EDstXPWrMaSneRWM8yUf6NFd/1/*)#j35f7r6v",
    "wpkh([0f056943/84'/0'/0']tpubDCx8y86cKonoPyTtj3f9NZLpBYoBNkbAzUdafMHhggjxkhF8Dny2aekWfDafywEMZEQaQjkK9Gxn7aN7usLRUQdYbvDgcnmYRf72khPEouL/1/*)#fzltz6me",
    "sh(wpkh([0f056943/49'/0'/0']tpubDDbPekoxnr7CaZUbYJVai5nbC2hUKEFeUDddcqhjQkeNo8wqk7qY1MuxDjBGwPESKui5XEH6hu21VfBXJbn8PZrFuwasiDAcyfA7Ao8WAsA/1/*))#cdnlkxr8",
    "tr([0f056943/86'/0'/0']tpubDCrr3F1M4TwZdFptiTXmjHpcdQMYNBzM9vA3gLGtB5tYUL6CFeNNNoK89xxqFowY9jzUsTDfZirSmfy9ZnjBuNVfxLYthQXoVvr3ja1jRrA/1/*)#tzygl3dl"
  ],
  "receive": [
    "pkh([0f056943/44'/0'/0']tpubDDpWvmUrPZrhSPmUzCMBHffvC3HyMAPnWDSAQNBTnj1iZeJa7BZQEttFiP4DS4GCcXQHezdXhn86Hj6LHX5EDstXPWrMaSneRWM8yUf6NFd/0/*)#r93grk25",
    "wpkh([0f056943/84'/0'/0']tpubDCx8y86cKonoPyTtj3f9NZLpBYoBNkbAzUdafMHhggjxkhF8Dny2aekWfDafywEMZEQaQjkK9Gxn7aN7usLRUQdYbvDgcnmYRf72khPEouL/0/*)#ck62l0tp",
    "sh(wpkh([0f056943/49'/0'/0']tpubDDbPekoxnr7CaZUbYJVai5nbC2hUKEFeUDddcqhjQkeNo8wqk7qY1MuxDjBGwPESKui5XEH6hu21VfBXJbn8PZrFuwasiDAcyfA7Ao8WAsA/0/*))#dvafwekc",
    "tr([0f056943/86'/0'/0']tpubDCrr3F1M4TwZdFptiTXmjHpcdQMYNBzM9vA3gLGtB5tYUL6CFeNNNoK89xxqFowY9jzUsTDfZirSmfy9ZnjBuNVfxLYthQXoVvr3ja1jRrA/0/*)#6kpfzya8"
  ]
}

edouardparis · 2026-04-07T08:21:12Z

I do not think it is part of the bhwi device commands scope, which should be reserved for commands like listing devices, getting firmware version and updating firmware.

I think it should be part of its own commands set, like:

bhwi descriptor list
bhwi descriptor register
bhwi descriptor get

etc

trevarj · 2026-04-07T15:38:20Z

I do not think it is part of the bhwi device commands scope, which should be reserved for commands like listing devices, getting firmware version and updating firmware.

I think it should be part of its own commands set, like:
bhwi descriptor list
bhwi descriptor register
bhwi descriptor get
etc

Nice, I like that too. Let me fix it up.

trevarj · 2026-04-07T20:53:02Z

@edouardparis changed to what you said above - cargo r -- descriptor list

edouardparis · 2026-04-08T08:13:25Z

the command descriptor list is just a wrapper on top of get xpub that list the "common" descriptors.
But as a user, I expect it to list the registered descriptors (which is not possible for some hardware wallets), too. I do not know if we should change the command name, or simply document it.

trevarj · 2026-04-08T08:34:31Z

the command descriptor list is just a wrapper on top of get xpub that list the "common" descriptors.

@edouardparis Right, just wanted to work towards parity with Python HWI. They're just descriptors for pubkeys it seems.

Maybe deeper commands like descriptor list pubkeys, descriptor list registered ?

Or:
descriptor list <- common pubkey descriptors
descript list --registered <-- actually registered within device

edouardparis · 2026-04-08T14:45:21Z

descriptor list pubkeys or descriptor pubkeys are fine for me for now, we can reserve the descriptor list for later.

edouardparis · 2026-04-08T08:03:47Z

bhwi-cli/src/get_descriptors.rs

+                    serde_json::json!(
+                    {
+                        "receive": receive,
+                        "internal": internal


what means internal ? is it the change ?

Yes. I can change it but I wanted parity with HWI. I actually like "change" better but internal is fine too

Funny that "internal" makes sense for the case of utxos refresh to reset timelocks, while "change" relates to a transactional exchange. I agree to keep it as it is.

I tried and I got same result than your PR description.
Internal and receive are the same set of xpubs, is it the hwi behavior ?

@edouardparis same xpubs but path should have 1 for internal and 0 for receive.

Coldcard simulator:
(ignore checksum difference cause of the h vs ')

Running `/home/trev/Workspace/rust-projects/bhwi/target/debug/bhwi --format json descriptor pubkeys` { "internal": [ "pkh([0f056943/44'/0'/0']tpubDDpWvmUrPZrhSPmUzCMBHffvC3HyMAPnWDSAQNBTnj1iZeJa7BZQEttFiP4DS4GCcXQHezdXhn86Hj6LHX5EDstXPWrMaSneRWM8yUf6NFd/1/*)#j35f7r6v", "wpkh([0f056943/84'/0'/0']tpubDCx8y86cKonoPyTtj3f9NZLpBYoBNkbAzUdafMHhggjxkhF8Dny2aekWfDafywEMZEQaQjkK9Gxn7aN7usLRUQdYbvDgcnmYRf72khPEouL/1/*)#fzltz6me", "sh(wpkh([0f056943/49'/0'/0']tpubDDbPekoxnr7CaZUbYJVai5nbC2hUKEFeUDddcqhjQkeNo8wqk7qY1MuxDjBGwPESKui5XEH6hu21VfBXJbn8PZrFuwasiDAcyfA7Ao8WAsA/1/*))#cdnlkxr8", "tr([0f056943/86'/0'/0']tpubDCrr3F1M4TwZdFptiTXmjHpcdQMYNBzM9vA3gLGtB5tYUL6CFeNNNoK89xxqFowY9jzUsTDfZirSmfy9ZnjBuNVfxLYthQXoVvr3ja1jRrA/1/*)#tzygl3dl" ], "receive": [ "pkh([0f056943/44'/0'/0']tpubDDpWvmUrPZrhSPmUzCMBHffvC3HyMAPnWDSAQNBTnj1iZeJa7BZQEttFiP4DS4GCcXQHezdXhn86Hj6LHX5EDstXPWrMaSneRWM8yUf6NFd/0/*)#r93grk25", "wpkh([0f056943/84'/0'/0']tpubDCx8y86cKonoPyTtj3f9NZLpBYoBNkbAzUdafMHhggjxkhF8Dny2aekWfDafywEMZEQaQjkK9Gxn7aN7usLRUQdYbvDgcnmYRf72khPEouL/0/*)#ck62l0tp", "sh(wpkh([0f056943/49'/0'/0']tpubDDbPekoxnr7CaZUbYJVai5nbC2hUKEFeUDddcqhjQkeNo8wqk7qY1MuxDjBGwPESKui5XEH6hu21VfBXJbn8PZrFuwasiDAcyfA7Ao8WAsA/0/*))#dvafwekc", "tr([0f056943/86'/0'/0']tpubDCrr3F1M4TwZdFptiTXmjHpcdQMYNBzM9vA3gLGtB5tYUL6CFeNNNoK89xxqFowY9jzUsTDfZirSmfy9ZnjBuNVfxLYthQXoVvr3ja1jRrA/0/*)#6kpfzya8" ] }

➜ ./hwi.py --emulators --fingerprint "0f056943" getdescriptors | jq { "receive": [ "pkh([0f056943/44h/0h/0h]tpubDDpWvmUrPZrhSPmUzCMBHffvC3HyMAPnWDSAQNBTnj1iZeJa7BZQEttFiP4DS4GCcXQHezdXhn86Hj6LHX5EDstXPWrMaSneRWM8yUf6NFd/0/*)#s5whevah", "wpkh([0f056943/84h/0h/0h]tpubDCx8y86cKonoPyTtj3f9NZLpBYoBNkbAzUdafMHhggjxkhF8Dny2aekWfDafywEMZEQaQjkK9Gxn7aN7usLRUQdYbvDgcnmYRf72khPEouL/0/*)#t89494uz", "sh(wpkh([0f056943/49h/0h/0h]tpubDDbPekoxnr7CaZUbYJVai5nbC2hUKEFeUDddcqhjQkeNo8wqk7qY1MuxDjBGwPESKui5XEH6hu21VfBXJbn8PZrFuwasiDAcyfA7Ao8WAsA/0/*))#fuwje7w6" ], "internal": [ "pkh([0f056943/44h/0h/0h]tpubDDpWvmUrPZrhSPmUzCMBHffvC3HyMAPnWDSAQNBTnj1iZeJa7BZQEttFiP4DS4GCcXQHezdXhn86Hj6LHX5EDstXPWrMaSneRWM8yUf6NFd/1/*)#pqtkyed0", "wpkh([0f056943/84h/0h/0h]tpubDCx8y86cKonoPyTtj3f9NZLpBYoBNkbAzUdafMHhggjxkhF8Dny2aekWfDafywEMZEQaQjkK9Gxn7aN7usLRUQdYbvDgcnmYRf72khPEouL/1/*)#6nq5cqv6", "sh(wpkh([0f056943/49h/0h/0h]tpubDDbPekoxnr7CaZUbYJVai5nbC2hUKEFeUDddcqhjQkeNo8wqk7qY1MuxDjBGwPESKui5XEH6hu21VfBXJbn8PZrFuwasiDAcyfA7Ao8WAsA/1/*))#uaqyppm9" ] }

trevarj · 2026-04-08T17:51:42Z

@edouardparis changed to descriptor pubkeys. Thanks

bhwi/src/common/commands/get_descriptor.rs

edouardparis · 2026-04-09T08:08:50Z

while running with ledger testnet app:

Error: hwi device error: interpreter error: unexpected result: []

Caused by:
    0: interpreter error: unexpected result: []
    1: unexpected result: []

Which makes sense the ledger testnet app refuses derivation paths for mainnet.

Analogous to Python HWI's getdescriptors.

trevarj · 2026-04-09T10:43:44Z

while running with ledger testnet app:
Error: hwi device error: interpreter error: unexpected result: []

Caused by:
    0: interpreter error: unexpected result: []
    1: unexpected result: []
Which makes sense the ledger testnet app refuses derivation paths for mainnet.

Not a nice error message 😩
Error message will need to be reworked somehow I think. Need more context there.

trevarj requested a review from edouardparis April 4, 2026 05:49

trevarj force-pushed the getdescriptors branch from 2964e9c to f420907 Compare April 7, 2026 20:52

edouardparis reviewed Apr 8, 2026

View reviewed changes

trevarj force-pushed the getdescriptors branch from f420907 to 74e9cae Compare April 8, 2026 17:50

trevarj changed the title ~~bhwi-cli: add GetDescriptors command~~ bhwi-cli: add descriptors pubkeys command Apr 8, 2026

trevarj requested a review from edouardparis April 8, 2026 17:51

edouardparis reviewed Apr 9, 2026

View reviewed changes

bhwi/src/common/commands/get_descriptor.rs Outdated Show resolved Hide resolved

bhwi-cli: add descriptor pubkeys command

82b16d9

Analogous to Python HWI's getdescriptors.

trevarj force-pushed the getdescriptors branch from 74e9cae to 82b16d9 Compare April 9, 2026 08:12

edouardparis merged commit a59d289 into wizardsardine:main Apr 9, 2026
7 checks passed

Conversation

trevarj commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

edouardparis commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trevarj commented Apr 7, 2026

Uh oh!

trevarj commented Apr 7, 2026

Uh oh!

edouardparis commented Apr 8, 2026

Uh oh!

trevarj commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

edouardparis commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

edouardparis Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

trevarj Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

edouardparis Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

edouardparis Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

trevarj Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

trevarj commented Apr 8, 2026

Uh oh!

Uh oh!

edouardparis commented Apr 9, 2026

Uh oh!

trevarj commented Apr 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

trevarj commented Apr 4, 2026 •

edited

Loading

edouardparis commented Apr 7, 2026 •

edited

Loading

trevarj commented Apr 8, 2026 •

edited

Loading

edouardparis commented Apr 8, 2026 •

edited

Loading