(Spike) APR Reward Notifier #158
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkeating
changed the title
apbendi
reviewed
Dec 3, 2025
| uint256 public constant MAX_REWARD_INTERVAL = 365 days; | ||
|
|
||
| /// @notice APR threshold in basis points. | ||
| uint16 public targetAPR; |
Collaborator
There was a problem hiding this comment.
Consider changing to aprCap or similar
apbendi
reviewed
Dec 3, 2025
|
|
||
| // Avoids revert in underlying staker if scaled reward rate is 0 | ||
| if (amountToNotify == 0 && (RECEIVER.scaledRewardRate() / RECEIVER.SCALE_FACTOR()) == 0) { | ||
| return; |
apbendi
reviewed
Dec 3, 2025
| // Calculate the maximum amount we can notify without exceeding the target | ||
| uint256 maxAllowableAmount = _calculateMaxNotifyAmount(currentAPR); | ||
| amountToNotify = rewardAmount > maxAllowableAmount ? maxAllowableAmount : rewardAmount; | ||
| nextRewardTime = block.timestamp + rewardInterval; |
Collaborator
There was a problem hiding this comment.
If we're past the reward interval, but currently at/above the cap, do we want to extend the next reward time? Or just prevent reward notification until that changes?
|
Coverage after merging feature/add-apy-reward-notifier into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.