Properly handle final sigma lowercase#56
Open
Jules-Bertholet wants to merge 1 commit intowithoutboats:masterfrom
Open
Properly handle final sigma lowercase#56Jules-Bertholet wants to merge 1 commit intowithoutboats:masterfrom
Jules-Bertholet wants to merge 1 commit intowithoutboats:masterfrom
Conversation
The rules for determining how a Greek sigma should be lowercased are more complex than just "is it the last character in the word." The full rule is defined in the Unicode Standard under "Final_Sigma": <https://www.unicode.org/versions/Unicode15.1.0/ch03.pdf#G54277> Implementing the rules ourselves would require shipping static data for the `Case_Ignorable` Unicode property. So this commit instead uses the standard library implementation, which unfortunately costs a heap allocation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rules for determining how a Greek sigma should be lowercased are more complex than just "is it the last character in the word." The full rule is defined in the Unicode Standard under "Final_Sigma": https://www.unicode.org/versions/Unicode15.1.0/ch03.pdf#G54277
Implementing the rules in
heckwould require shipping static data for theCase_IgnorableUnicode property. So this commit instead uses the standard library implementation, which unfortunately costs an extra heap allocation.