Open
Conversation
Author
|
Upon Further Testing. PHF is actually slower by a lot in this case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Projects Like Strum and a few of mine create an Enum of Case Options. Let's go ahead and provide one.
To Uppercase and To Lowercase
I know that support for Uppercase and Lowercase is not something provided in the library. However, the Enum would not be very useful if it didn't provide the options that get used.
The adding of the PHF crate.The performance of the default match statement is not the best. However, PHF can improve the performance a bit and if the user wants to keep the dependencies low they don't need to have it.