Open
Conversation
Creating/Destroying the otel_exporter_pid for each test was not cooperating with all the tests running simultaneously. Almost certainly due to the race condition in OtelHlper.otel_pid_reporter altering the global state to configure where the spans were being sent Co-authored-by: Gray <surrsurus@users.noreply.github.com>
Did this because the first test was always failing Co-authored-by: Gray <surrsurus@users.noreply.github.com>
commit 6eea732 Merge: 30b17ec b37f1b1 Author: Kevin Tayah <ktayah@yahoo.com> Date: Mon Oct 23 10:07:42 2023 -0400 Merge branch 'feature/add-expand-all-maps-opt' commit b37f1b1 Author: Kevin Tayah <ktayah@yahoo.com> Date: Sat Oct 21 11:34:58 2023 -0400 Added default to expand_maps commit 30b17ec Merge: af35d6e 299d0f6 Author: Kevin Tayah <ktayah@yahoo.com> Date: Mon Oct 16 11:05:48 2023 -0400 Merge branch 'feature/add-expand-all-maps-opt' commit af35d6e Author: Kevin Tayah <32495802+ktayah@users.noreply.github.com> Date: Sun Oct 15 19:47:12 2023 -0400 Feature/add expand all maps opt (#1) * Add ability to expand_all_maps from requested_attributes * Add test for with_span w/ expand_map option * Add documentation * Fix error introduced * Format commit 299d0f6 Author: Kevin Tayah <ktayah@yahoo.com> Date: Sun Oct 15 19:42:59 2023 -0400 Format commit 012c8a2 Author: Kevin Tayah <ktayah@yahoo.com> Date: Sun Oct 15 19:42:56 2023 -0400 Fix error introduced commit c759d36 Author: Kevin Tayah <ktayah@yahoo.com> Date: Sun Oct 15 19:41:33 2023 -0400 Add documentation commit 66fa995 Author: Kevin Tayah <ktayah@yahoo.com> Date: Sun Oct 15 16:03:00 2023 -0400 Add test for with_span w/ expand_map option commit 6e85349 Author: Kevin Tayah <ktayah@yahoo.com> Date: Sun Oct 15 15:46:01 2023 -0400 Add ability to expand_all_maps from requested_attributes
jeffdeville
force-pushed
the
feature/expand-maps-and-kind
branch
from
b396c92 to
5927bd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
span.kindchangesexpand_mapschanges