This repository was archived by the owner on Feb 10, 2025. It is now read-only.
feat(cloudflare): Enables image service onerror redirect #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ee60f0a The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ekwoka
changed the title
Member
|
Hi, we moved the cloudflare adapter in a new repository: https://github.com/withastro/astro/tree/main/packages/integrations/cloudflare We will achieve this repository soon, so if you wish to land this PR, you'll have to create a new one. |
Author
|
Awesome :sigh: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
onerror=redirectto Cloudflare image transform params. This will allow images to continue to work after hitting Cloudflare's free limit. (docs)I am not positive how this impacts sites that don't have the image service set up at all, since it might then load the original image as opposed to just erroring and loading nothing as it does now. If it still applies when the image service is disabled entirely, and shows the underlying image, it could cause some confusion with users not realizing the service isn't turned on.
Testing
None. It's a hardcoded value, and I more want to introduce the idea to see if this should be a configurable value, or just always applied.
Docs
This might be worth mentioning in the docs. I can make a PR to those once this is decided on.
Should this be a configurable? Currently there aren't configurations to the options, though maybe it could work with the
Imageto offer it if that is the preferred out.