Open
Conversation
Codecov Report
@@ Coverage Diff @@
## mizar #24 +/- ##
==========================================
- Coverage 34.52% 34.39% -0.13%
==========================================
Files 97 98 +1
Lines 17693 17759 +66
==========================================
Hits 6108 6108
- Misses 10712 10778 +66
Partials 873 873
|
* Added tls configuration for api server * Added https configuration for the client * Update cli for Https Certificates env variable
himanshuvar
force-pushed
the
secure-connection-opensds
branch
from
845d294 to
e3d0d09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: To support secure clients and hotpot osdsapiserver connection
Which issue this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes opensds 1170
Special notes for your reviewer:
Please generate the certificates using the following:
https://github.com/jsha/minica