Open
Conversation
…lasses. Move LookupTable inside Base32Encoding to make this work without making it public.
Author
|
By the way, if you'd rather not merge this, I respect that, but would appreciate to know early - so I can plan on using the fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The story: I need to encode from/decode to a fixed number of bytes in a struct, not a byte[].
The cleanest way to make use of your excellent code was to interface with the 4 methods taking "byte *" as unencoded data.
Alternatively, if ToBase32Unsafe() and ToBytesUnsafe() took "byte *", I could interface with those 2 methods instead - but I felt that change was a bit more invasive, and would be less performant (in my code, lengths/groupCounts/remainders can be const).
Cheers!