Update protobuf dependency to next major version #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No other changes required due to version upgrade? Does this affect to other components using this library? |
Contributor
Author
I think all of the components that use this library (transport service, mqtt library) don't use the protobuf library directly so they should be unaffected. At least I can't think of anything that might break other than some internal testing tools. |
MauriKuorilehto
approved these changes
Jun 18, 2025
MauriKuorilehto
left a comment
MauriKuorilehto
left a comment
There was a problem hiding this comment.
If you consider that this is not affecting to clients, feel free to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protobuf v5 is still supported until 03/2026, but we can already take the latest version into use since it can help with backend testing setup (due to other libraries depending on protobuf).