Transport: add support for scratchpad as chunk #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| if acc is not None: | ||
| if (acc["seq"] != request.seq | ||
| or acc["total_size"] != total_size | ||
| or offset == 0): |
There was a problem hiding this comment.
visually indented line with same indent as next logical line
| "--gateway_max_scratchpad_size", | ||
| type=self.str2int, | ||
| default=os.environ.get("WM_GW_MAX_SCRAT_SIZE", None), | ||
| help=("Maximum scratchpad size a gateway can accept. If scratchpad is bigger" |
| logging.info("Scratchpad fully received for %s", request.sink_id) | ||
|
|
||
| try: | ||
| res = sink.upload_scratchpad(request.seq, acc["buffer"]) |
Contributor
There was a problem hiding this comment.
What happens with the below _send_otap_response call if this throws an exception? Should the res be set to some error before this try block?
Contributor
There was a problem hiding this comment.
On the other hand, it doesn't seem that it might throw an exception, and other call is without a try. Do you remember why you added this inside a try block?
| type=self.str2int, | ||
| default=os.environ.get("WM_GW_MAX_SCRAT_SIZE", None), | ||
| help=("Maximum scratchpad size a gateway can accept. If scratchpad is bigger" | ||
| "it must be sent as chunks smaller or equal to this value"), |
Contributor
There was a problem hiding this comment.
This is consistent with the backend api naming and documentation, but should it be clarified more that it's the max chunk size and it's only a "suggestion" for the backend (since there is no limit in the code for max chunk size)?
sgunes-wirepas
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature can be tested with Console on this branch:
https://wirepas-tools.github.io/mqtt-console/chunk/