Adding a retain flag supported by mqtt in the gateway and status topi… #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| file_vars["gateway_version"] = env_vars["WM_GW_VERSION"] | ||
| file_vars["ignored_endpoints_filter"] = env_vars["WM_GW_IGNORED_ENDPOINTS_FILTER"] | ||
| file_vars["whitened_endpoints_filter"] = env_vars["WM_GW_WHITENED_ENDPOINTS_FILTER"] | ||
| file_vars["mqtt_retain_flag_supported"] = env_vars["WM_SERVICES_MQTT_RETAIN_FLAG_SUPPORTED"] |
There was a problem hiding this comment.
Black would make changes.
line too long (92 > 79 characters)
pgaucherand
reviewed
Nov 9, 2022
Contributor
pgaucherand
left a comment
pgaucherand
left a comment
There was a problem hiding this comment.
Just a minor comment from, otherwise looks good.
…cs in mqtt. Some brokers (like AWS iot core) do not support retain messages. Add option to transport to specify if the retain is supported by broker. New MQTT topics can be used in the case where the mqtt broker does not support retained message and we would like to know the status of the gateways as soon as possible. The concerned topics in the mqtt broker are : gw-request/get_gw_status gw-response/get_gw_status/<gw-id>/<sink-id>
LePailleurThibault
force-pushed
the
retain_control
branch
from
643764f to
3637f84
Compare
…tus branch to suppress it and simplify branches) + PR#236
| file_vars["gateway_version"] = env_vars["WM_GW_VERSION"] | ||
| file_vars["ignored_endpoints_filter"] = env_vars["WM_GW_IGNORED_ENDPOINTS_FILTER"] | ||
| file_vars["whitened_endpoints_filter"] = env_vars["WM_GW_WHITENED_ENDPOINTS_FILTER"] | ||
| file_vars["mqtt_retain_flag_not_supported"] = env_vars["WM_SERVICES_MQTT_RETAIN_FLAG_NOT_SUPPORTED"] |
There was a problem hiding this comment.
Black would make changes.
line too long (100 > 79 characters)
| self.data_event_id = None | ||
|
|
||
| if not self.retain_supported: | ||
| logging.info("Gateway status is sent every %d seconds", settings.mqtt_send_gateway_status_period_s) |
|
|
||
| self.mqtt.add_argument( | ||
| "--mqtt_send_gateway_status_period_s", | ||
| default=os.environ.get("WM_SERVICES_MQTT_SEND_GATEWAY_STATUS_PERIOD_S", 20), |
|
|
||
| self.mqtt.add_argument( | ||
| "--mqtt_retain_flag_not_supported", | ||
| default=os.environ.get("WM_SERVICES_MQTT_RETAIN_FLAG_NOT_SUPPORTED", False), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cs in mqtt.
Some brokers (like AWS iot core) do not support retain messages. Add option to transport to specify if the retain is supported by broker.
New MQTT topics can be used in the case where the mqtt broker does not support retained message and we would like to know the status of the gateways as soon as possible.
The concerned topics in the mqtt broker are :
gw-request/get_gw_status
gw-response/get_gw_status//
Closes # .
Brief pull request description