Skip to content

Dont store functiondata permanently #3472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Astralcircle merged 1 commit into from
Dec 7, 2025
Merged

Dont store functiondata permanently #3472

Astralcircle merged 1 commit into from
Dec 7, 2025

Conversation

@wrefgtzweve
Copy link
Member

@wrefgtzweve wrefgtzweve commented Dec 7, 2025 •
edited
Loading

The functiondata would easily contain 20k+ entries while it was rarely being used, generating it when needed would save some memory.

@Astralcircle Astralcircle merged commit 3a5c965 into wiremod:master Dec 7, 2025
1 check passed
@wrefgtzweve wrefgtzweve deleted the cleanup-functiondata branch December 7, 2025 16:06
@Denneisk
Copy link
Member

Denneisk commented Dec 7, 2025 •
edited
Loading

Meh, could have stored it in a weak table for the best of both worlds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Astralcircle Astralcircle Astralcircle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wrefgtzweve @Denneisk @Astralcircle