Minor changes in WireLib #3185
Merged
Minor changes in WireLib #3185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
What's the purpose to changing the location to |
Contributor
Author
For supporting different resolutions, isn't it logical? The text position shifts only slightly. |
Member
|
Huh, seems like it's some developer leftover that isn't even used anywhere. I thought it was related to the Wire debugger and was worried making the position dynamic might mess with how it avoids the toolgun HUD. |
Denneisk
approved these changes
Nov 25, 2024
Contributor
Author
|
I think this dead code should not be removed, as some addons that use WireLib may rely on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use color_white instead of Color(255, 255, 255, 255)
Use ScrH() / 5 instead of 200
Use less bits for WireLib.AddNotify
Make NOTIFYSOUND_DRIP5 equal NOTIFYSOUND_DRIP4 because this sound does not exist