Skip to content

WPB-17187: adding support for full redirection along with fragment #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohitrajain merged 1 commit into from
Apr 17, 2025
Merged

WPB-17187: adding support for full redirection along with fragment #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,5 @@ jobs:
aws s3 rm s3://${{ secrets.BUCKET }}/latest --recursive
aws s3 sync tmp_extracted/latest s3://${{ secrets.BUCKET }}/latest

# will be removed in the next commit
aws s3 rm s3://${{ secrets.BUCKET }}/site --recursive

aws s3 cp tmp_extracted/versions.json s3://${{ secrets.BUCKET }}/versions.json
rm -rf tmp_extracted
2 changes: 0 additions & 2 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,5 @@ jobs:
aws s3 rm s3://${{ secrets.DEV_BUCKET }}/latest --recursive
aws s3 sync tmp_extracted/latest s3://${{ secrets.DEV_BUCKET }}/latest

aws s3 rm s3://${{ secrets.DEV_BUCKET }}/site --recursive

aws s3 cp tmp_extracted/versions.json s3://${{ secrets.DEV_BUCKET }}/versions.json
rm -rf tmp_extracted
9 changes: 5 additions & 4 deletions .overrides/404.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,15 @@ <h1>Page moved or not found</h1>
<script>
(function () {
const path = window.location.pathname;
const hash = window.location.hash;
const isVersioned = path.startsWith("/latest") || /^\/v\d/.test(path);
if (!isVersioned) {
const newPath = "/latest" + path;
const newPath = "/latest" + path + hash;
const link = document.getElementById("redirect-link");
link.href = newPath;
link.textContent = newPath; // Set both href and visible text
//window.location.replace(newPath);
link.textContent = newPath;
// window.location.replace(newPath);
}
})();
</script>
{% endblock %}
{% endblock %}
Loading